Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme + followup-problem in pr-body #4

Closed
wants to merge 10 commits into from
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[submodule "path_to_submodule"]
path = jfr-datasource
url = git@github.com:gunnarmorling/jfr-datasource.git
url = https://github.com/gunnarmorling/jfr-datasource.git

15 changes: 11 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,14 @@ It also demonstrates how to export Flight Recorder events in realtime via MicroP
Update Feb. 8th: the example has been expanded to show the usage of the [JFR datasource](https://github.com/rh-jmc-team/jfr-datasource) for Grafana.

## Build

Make sure to have Java 14 installed.
Run the following to build this project:

### === PREREQUISITES ===
* make sure to use java 15 for the build
* :heavy_exclamation_mark: make sure to have a populated jfr-datasource subdirectory after checkout by
* either **git clone** ```--recurse-submodules``` on initial clone
* or ```git submodule update --init --recursive``` if you have already cloned
* jfr-datasource is a referenced git project which stays an empty folder if you just use ```git clone ...```
### === PREREQUISITES ===
* Run the following to build this project:
```shell
# Example service
mvn clean package -f example-service/pom.xml
Expand All @@ -25,6 +29,9 @@ mvn clean package -f jfr-datasource/pom.xml
docker-compose up --build
```

If you experience the following error message please scroll up and check the prerequisites
> POM file "jfr-datasource/pom.xml" specified the -f/--file command-line argument does not exist

Open the web application at http://localhost:8080/.
You then can connect to the running application on port 1898 using Mission Control,
start Flight Recorder and observe "JAX-RS" events in the recording.
Expand Down
4 changes: 2 additions & 2 deletions example-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>junit-jupiter</artifactId>
<version>1.15.0</version>
<version>1.15.3</version>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
<version>1.15.0</version>
<version>1.15.3</version>
</dependency>
<dependency>
<groupId>org.skyscreamer</groupId>
Expand Down