Skip to content

Commit f51e0ad

Browse files
authored
[Impeller] added test for bgra10xr png encoding (flutter#53182)
fixes: flutter/flutter#148851 depends on: - https://skia-review.googlesource.com/c/skcms/+/861638 - https://skia-review.googlesource.com/c/skia/+/861516 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent a611a82 commit f51e0ad

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

lib/ui/painting/image_encoding_unittests.cc

+22
Original file line numberDiff line numberDiff line change
@@ -469,6 +469,28 @@ TEST(ImageEncodingImpellerTest, PngEncoding10XR) {
469469
EXPECT_TRUE(png.ok());
470470
}
471471

472+
TEST(ImageEncodingImpellerTest, PngEncodingBGRA10XR) {
473+
int width = 100;
474+
int height = 100;
475+
SkImageInfo info = SkImageInfo::Make(
476+
width, height, kBGRA_10101010_XR_SkColorType, kUnpremul_SkAlphaType);
477+
478+
auto surface = SkSurfaces::Raster(info);
479+
SkCanvas* canvas = surface->getCanvas();
480+
481+
SkPaint paint;
482+
paint.setColor(SK_ColorBLUE);
483+
paint.setAntiAlias(true);
484+
485+
canvas->clear(SK_ColorWHITE);
486+
canvas->drawCircle(width / 2, height / 2, 100, paint);
487+
488+
sk_sp<SkImage> image = surface->makeImageSnapshot();
489+
490+
fml::StatusOr<sk_sp<SkData>> png = EncodeImage(image, ImageByteFormat::kPNG);
491+
EXPECT_TRUE(png.ok());
492+
}
493+
472494
#endif // IMPELLER_SUPPORTS_RENDERING
473495

474496
} // namespace testing

0 commit comments

Comments
 (0)