fix: update repository for catalog command (#3415)

Author: lev-ok

cli/commands/catalog/module/repo.go

@@ -3,6 +3,7 @@ package module
 import (
 	"context"
 	"fmt"
+	"net/url"
 	"os"
 	"path/filepath"
 	"regexp"
@@ -194,7 +195,12 @@ func (repo *Repo) clone(ctx context.Context) error {
 
 	repo.logger.Infof("Cloning repository %q to temporary directory %q", repo.cloneURL, repo.path)
 
-	if err := getter.Get(repo.path, strings.Trim(sourceURL.String(), "/"), getter.WithContext(ctx)); err != nil {
+	// We need to explicitly specify the reference, otherwise we will get an error:
+	// "fatal: The empty string is not a valid pathspec. Use . instead if you wanted to match all paths"
+	// when updating an existing repository.
+	sourceURL.RawQuery = (url.Values{"ref": []string{"HEAD"}}).Encode()
+
+	if err := getter.Get(repo.path, strings.Trim(sourceURL.String(), "/"), getter.WithContext(ctx), getter.WithMode(getter.ClientModeDir)); err != nil {
 		return errors.WithStackTrace(err)
 	}
 

test/integration_catalog_test.go

@@ -2,7 +2,6 @@ package test_test
 
 import (
 	"context"
-	"os"
 	"path/filepath"
 	"testing"
 
@@ -15,14 +14,27 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestScaffoldGitRepo(t *testing.T) {
+func TestCatalogGitRepoUpdate(t *testing.T) {
 	t.Parallel()
 
 	ctx := context.Background()
 
-	tempDir, err := os.MkdirTemp("", "catalog-*")
+	tempDir := t.TempDir()
+
+	_, err := module.NewRepo(ctx, log.New(), "github.com/gruntwork-io/terraform-fake-modules.git", tempDir)
 	require.NoError(t, err)
 
+	_, err = module.NewRepo(ctx, log.New(), "github.com/gruntwork-io/terraform-fake-modules.git", tempDir)
+	require.NoError(t, err)
+}
+
+func TestScaffoldGitRepo(t *testing.T) {
+	t.Parallel()
+
+	ctx := context.Background()
+
+	tempDir := t.TempDir()
+
 	repo, err := module.NewRepo(ctx, log.New(), "github.com/gruntwork-io/terraform-fake-modules.git", tempDir)
 	require.NoError(t, err)
 
@@ -36,8 +48,7 @@ func TestScaffoldGitModule(t *testing.T) {
 
 	ctx := context.Background()
 
-	tempDir, err := os.MkdirTemp("", "catalog-*")
-	require.NoError(t, err)
+	tempDir := t.TempDir()
 
 	repo, err := module.NewRepo(ctx, log.New(), "https://github.com/gruntwork-io/terraform-fake-modules.git", tempDir)
 	require.NoError(t, err)
@@ -75,8 +86,7 @@ func TestScaffoldGitModuleHttps(t *testing.T) {
 
 	ctx := context.Background()
 
-	tempDir, err := os.MkdirTemp("", "catalog-*")
-	require.NoError(t, err)
+	tempDir := t.TempDir()
 
 	repo, err := module.NewRepo(ctx, log.New(), "https://github.com/gruntwork-io/terraform-fake-modules", tempDir)
 	require.NoError(t, err)