Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing support #148

Open
palfrey opened this issue Aug 29, 2021 · 6 comments
Open

Add typing support #148

palfrey opened this issue Aug 29, 2021 · 6 comments

Comments

@palfrey
Copy link

palfrey commented Aug 29, 2021

Currently running mypy against something using this project gets error: Skipping analyzing 'furl': found module but no type hints or library stubs

@gruns
Copy link
Owner

gruns commented Aug 30, 2021

do you have the time and bandwidth to add types to icecream? 🙂

@palfrey
Copy link
Author

palfrey commented Sep 5, 2021

Turns out it's harder than that. icecream needs executing, which needs asttokens which needs astroid. Astroid has had some typing work, but it still is a way off (see pylint-dev/astroid#1024 (comment)). OTOH, if we ignore that, the others are more viable.

I've opened gristlabs/asttokens#72 to start this process, but the build system appears a bit broken there.

@gruns
Copy link
Owner

gruns commented Sep 10, 2021

@palfrey thank you for your efforts here! 🙌

@dsully
Copy link

dsully commented Sep 30, 2022

Looks like the asttokens change has been merged.

@palfrey
Copy link
Author

palfrey commented Oct 1, 2022

Yup. alexmojaki/executing#57 is my initial work there

@palfrey
Copy link
Author

palfrey commented Nov 24, 2023

And icecream with gruns/icecream#167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants