Skip to content

Commit 93153c0

Browse files
LinglingTongFredericHeem
authored andcommitted
Add xms-ids for PolicyInsights (Azure#17965)
* add xms-ids for PolicyInsights * Address code review feedback
1 parent 7b386ba commit 93153c0

File tree

7 files changed

+59
-14
lines changed

7 files changed

+59
-14
lines changed

specification/policyinsights/resource-manager/Microsoft.PolicyInsights/preview/2018-07-01-preview/policyTrackedResources.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,9 @@
239239
"items": {
240240
"$ref": "#/definitions/PolicyTrackedResource"
241241
},
242+
"x-ms-identifiers": [
243+
"trackedResourceId"
244+
],
242245
"readOnly": true
243246
},
244247
"nextLink": {

specification/policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyEvents.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,8 @@
699699
"type": "array",
700700
"items": {
701701
"$ref": "#/definitions/PolicyEvent"
702-
}
702+
},
703+
"x-ms-identifiers": []
703704
}
704705
}
705706
},

specification/policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyMetadata.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@
260260
"items": {
261261
"$ref": "#/definitions/ErrorDefinition"
262262
},
263+
"x-ms-identifiers": [],
263264
"readOnly": true
264265
},
265266
"additionalInfo": {
@@ -268,6 +269,7 @@
268269
"items": {
269270
"$ref": "#/definitions/TypedErrorInfo"
270271
},
272+
"x-ms-identifiers": [],
271273
"readOnly": true
272274
}
273275
}

specification/policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2019-10-01/policyStates.json

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1229,7 +1229,8 @@
12291229
"type": "array",
12301230
"items": {
12311231
"$ref": "#/definitions/PolicyState"
1232-
}
1232+
},
1233+
"x-ms-identifiers": []
12331234
}
12341235
}
12351236
},
@@ -1398,7 +1399,8 @@
13981399
"type": "array",
13991400
"items": {
14001401
"$ref": "#/definitions/ExpressionEvaluationDetails"
1401-
}
1402+
},
1403+
"x-ms-identifiers": []
14021404
},
14031405
"ifNotExistsDetails": {
14041406
"description": "Evaluation details of IfNotExists effect.",
@@ -1505,7 +1507,8 @@
15051507
"type": "array",
15061508
"items": {
15071509
"$ref": "#/definitions/Summary"
1508-
}
1510+
},
1511+
"x-ms-identifiers": []
15091512
}
15101513
}
15111514
},
@@ -1529,7 +1532,10 @@
15291532
"type": "array",
15301533
"items": {
15311534
"$ref": "#/definitions/PolicyAssignmentSummary"
1532-
}
1535+
},
1536+
"x-ms-identifiers": [
1537+
"policyAssignmentId"
1538+
]
15331539
}
15341540
}
15351541
},
@@ -1557,21 +1563,24 @@
15571563
"type": "array",
15581564
"items": {
15591565
"$ref": "#/definitions/ComplianceDetail"
1560-
}
1566+
},
1567+
"x-ms-identifiers": []
15611568
},
15621569
"policyDetails": {
15631570
"description": "The policy artifact summary at this level. For query scope level, it represents policy assignment summary. For policy assignment level, it represents policy definitions summary.",
15641571
"type": "array",
15651572
"items": {
15661573
"$ref": "#/definitions/ComplianceDetail"
1567-
}
1574+
},
1575+
"x-ms-identifiers": []
15681576
},
15691577
"policyGroupDetails": {
15701578
"description": "The policy definition group summary at this level.",
15711579
"type": "array",
15721580
"items": {
15731581
"$ref": "#/definitions/ComplianceDetail"
1574-
}
1582+
},
1583+
"x-ms-identifiers": []
15751584
}
15761585
}
15771586
},
@@ -1609,14 +1618,20 @@
16091618
"type": "array",
16101619
"items": {
16111620
"$ref": "#/definitions/PolicyDefinitionSummary"
1612-
}
1621+
},
1622+
"x-ms-identifiers": [
1623+
"policyDefinitionId"
1624+
]
16131625
},
16141626
"policyGroups": {
16151627
"description": "Policy definition group summary.",
16161628
"type": "array",
16171629
"items": {
16181630
"$ref": "#/definitions/PolicyGroupSummary"
1619-
}
1631+
},
1632+
"x-ms-identifiers": [
1633+
"policyGroupName"
1634+
]
16201635
}
16211636
}
16221637
},
@@ -1695,7 +1710,10 @@
16951710
"type": "array",
16961711
"items": {
16971712
"$ref": "#/definitions/Operation"
1698-
}
1713+
},
1714+
"x-ms-identifiers": [
1715+
"name"
1716+
]
16991717
}
17001718
}
17011719
},

specification/policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2020-07-01/checkPolicyRestrictions.json

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,10 @@
131131
"type": "array",
132132
"items": {
133133
"$ref": "#/definitions/PendingField"
134-
}
134+
},
135+
"x-ms-identifiers": [
136+
"field"
137+
]
135138
}
136139
},
137140
"required": [
@@ -186,6 +189,9 @@
186189
"items": {
187190
"$ref": "#/definitions/FieldRestrictions"
188191
},
192+
"x-ms-identifiers": [
193+
"field"
194+
],
189195
"readOnly": true
190196
},
191197
"contentEvaluationResult": {
@@ -196,7 +202,13 @@
196202
"type": "array",
197203
"items": {
198204
"$ref": "#/definitions/PolicyEvaluationResult"
199-
}
205+
},
206+
"x-ms-identifiers": [
207+
"/policyInfo/policyDefinitionId",
208+
"/policyInfo/policySetDefinitionId",
209+
"/policyInfo/policyDefinitionReferenceId",
210+
"/policyInfo/policyAssignmentId"
211+
]
200212
}
201213
},
202214
"readOnly": true
@@ -216,7 +228,8 @@
216228
"type": "array",
217229
"items": {
218230
"$ref": "#/definitions/FieldRestriction"
219-
}
231+
},
232+
"x-ms-identifiers": []
220233
}
221234
}
222235
},

specification/policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2021-01-01/attestations.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,7 @@
639639
"items": {
640640
"$ref": "#/definitions/AttestationEvidence"
641641
},
642+
"x-ms-identifiers": [],
642643
"description": "The evidence supporting the compliance state set in this attestation."
643644
},
644645
"provisioningState": {
@@ -704,6 +705,7 @@
704705
"items": {
705706
"$ref": "#/definitions/ErrorDefinition"
706707
},
708+
"x-ms-identifiers": [],
707709
"readOnly": true
708710
},
709711
"additionalInfo": {
@@ -712,6 +714,7 @@
712714
"items": {
713715
"$ref": "#/definitions/TypedErrorInfo"
714716
},
717+
"x-ms-identifiers": [],
715718
"readOnly": true
716719
}
717720
}

specification/policyinsights/resource-manager/Microsoft.PolicyInsights/stable/2021-10-01/remediations.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1078,6 +1078,9 @@
10781078
"items": {
10791079
"$ref": "#/definitions/RemediationDeployment"
10801080
},
1081+
"x-ms-identifiers": [
1082+
"remediatedResourceId"
1083+
],
10811084
"readOnly": true
10821085
},
10831086
"nextLink": {
@@ -1318,6 +1321,7 @@
13181321
"items": {
13191322
"$ref": "#/definitions/ErrorDefinition"
13201323
},
1324+
"x-ms-identifiers": [],
13211325
"readOnly": true
13221326
},
13231327
"additionalInfo": {
@@ -1326,6 +1330,7 @@
13261330
"items": {
13271331
"$ref": "#/definitions/TypedErrorInfo"
13281332
},
1333+
"x-ms-identifiers": [],
13291334
"readOnly": true
13301335
}
13311336
}

0 commit comments

Comments
 (0)