Skip to content

Commit 70825ad

Browse files
committed
Replace jsr305's GuardedBy with Error Prone's
We should avoid jsr305 and error prone's has the same semantics.
1 parent 7b5d069 commit 70825ad

File tree

53 files changed

+55
-50
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+55
-50
lines changed

alts/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ java_library(
1818
"@com_google_protobuf//:protobuf_java",
1919
"@com_google_protobuf//:protobuf_java_util",
2020
artifact("com.google.code.findbugs:jsr305"),
21+
artifact("com.google.errorprone:error_prone_annotations"),
2122
artifact("com.google.guava:guava"),
2223
artifact("io.netty:netty-buffer"),
2324
artifact("io.netty:netty-codec"),

alts/src/main/java/io/grpc/alts/internal/AsyncSemaphore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616

1717
package io.grpc.alts.internal;
1818

19+
import com.google.errorprone.annotations.concurrent.GuardedBy;
1920
import io.netty.channel.ChannelFuture;
2021
import io.netty.channel.ChannelHandlerContext;
2122
import io.netty.channel.ChannelPromise;
2223
import java.util.LinkedList;
2324
import java.util.Queue;
24-
import javax.annotation.concurrent.GuardedBy;
2525

2626
/** Provides a semaphore primitive, without blocking waiting on permits. */
2727
final class AsyncSemaphore {

android/src/main/java/io/grpc/android/AndroidChannelBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.google.common.annotations.VisibleForTesting;
2929
import com.google.common.base.Preconditions;
3030
import com.google.errorprone.annotations.InlineMe;
31+
import com.google.errorprone.annotations.concurrent.GuardedBy;
3132
import io.grpc.CallOptions;
3233
import io.grpc.ClientCall;
3334
import io.grpc.ConnectivityState;
@@ -41,7 +42,6 @@
4142
import io.grpc.internal.GrpcUtil;
4243
import java.util.concurrent.TimeUnit;
4344
import javax.annotation.Nullable;
44-
import javax.annotation.concurrent.GuardedBy;
4545

4646
/**
4747
* Builds a {@link ManagedChannel} that, when provided with a {@link Context}, will automatically

api/src/main/java/io/grpc/ConfiguratorRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616

1717
package io.grpc;
1818

19+
import com.google.errorprone.annotations.concurrent.GuardedBy;
1920
import java.util.ArrayList;
2021
import java.util.Collections;
2122
import java.util.List;
22-
import javax.annotation.concurrent.GuardedBy;
2323

2424
/**
2525
* A registry for {@link Configurator} instances.

api/src/main/java/io/grpc/ManagedChannelRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import com.google.common.annotations.VisibleForTesting;
2020
import com.google.common.base.Preconditions;
21+
import com.google.errorprone.annotations.concurrent.GuardedBy;
2122
import java.net.SocketAddress;
2223
import java.net.URI;
2324
import java.net.URISyntaxException;
@@ -30,7 +31,6 @@
3031
import java.util.List;
3132
import java.util.logging.Level;
3233
import java.util.logging.Logger;
33-
import javax.annotation.concurrent.GuardedBy;
3434
import javax.annotation.concurrent.ThreadSafe;
3535

3636
/**

api/src/main/java/io/grpc/MetricInstrumentRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121

2222
import com.google.common.annotations.VisibleForTesting;
2323
import com.google.common.base.Strings;
24+
import com.google.errorprone.annotations.concurrent.GuardedBy;
2425
import java.util.Arrays;
2526
import java.util.Collections;
2627
import java.util.HashSet;
2728
import java.util.List;
2829
import java.util.Set;
29-
import javax.annotation.concurrent.GuardedBy;
3030

3131
/**
3232
* A registry for globally registered metric instruments.

api/src/main/java/io/grpc/NameResolverRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import com.google.common.annotations.VisibleForTesting;
2222
import com.google.common.collect.ImmutableMap;
23+
import com.google.errorprone.annotations.concurrent.GuardedBy;
2324
import java.net.URI;
2425
import java.util.ArrayList;
2526
import java.util.Collections;
@@ -31,7 +32,6 @@
3132
import java.util.logging.Level;
3233
import java.util.logging.Logger;
3334
import javax.annotation.Nullable;
34-
import javax.annotation.concurrent.GuardedBy;
3535
import javax.annotation.concurrent.ThreadSafe;
3636

3737
/**

api/src/main/java/io/grpc/ServerRegistry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818

1919
import com.google.common.annotations.VisibleForTesting;
2020
import com.google.common.base.Preconditions;
21+
import com.google.errorprone.annotations.concurrent.GuardedBy;
2122
import java.util.ArrayList;
2223
import java.util.Collections;
2324
import java.util.Comparator;
2425
import java.util.LinkedHashSet;
2526
import java.util.List;
2627
import java.util.logging.Level;
2728
import java.util.logging.Logger;
28-
import javax.annotation.concurrent.GuardedBy;
2929
import javax.annotation.concurrent.ThreadSafe;
3030

3131
/**

binder/src/androidTest/java/io/grpc/binder/HostServices.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import androidx.lifecycle.LifecycleService;
3030
import com.google.auto.value.AutoValue;
3131
import com.google.common.base.Supplier;
32+
import com.google.errorprone.annotations.concurrent.GuardedBy;
3233
import io.grpc.Server;
3334
import java.io.IOException;
3435
import java.util.HashMap;
@@ -38,7 +39,6 @@
3839
import java.util.logging.Level;
3940
import java.util.logging.Logger;
4041
import javax.annotation.Nullable;
41-
import javax.annotation.concurrent.GuardedBy;
4242

4343
/**
4444
* A test helper class for creating android services to host gRPC servers.

binder/src/androidTest/java/io/grpc/binder/internal/BinderClientTransportTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.google.common.util.concurrent.Futures;
2828
import com.google.common.util.concurrent.ListenableFuture;
2929
import com.google.common.util.concurrent.SettableFuture;
30+
import com.google.errorprone.annotations.concurrent.GuardedBy;
3031
import com.google.protobuf.Empty;
3132
import io.grpc.CallOptions;
3233
import io.grpc.ClientStreamTracer;
@@ -64,7 +65,6 @@
6465
import java.util.concurrent.ScheduledExecutorService;
6566
import java.util.concurrent.TimeUnit;
6667
import javax.annotation.Nullable;
67-
import javax.annotation.concurrent.GuardedBy;
6868
import org.junit.After;
6969
import org.junit.Before;
7070
import org.junit.Test;

0 commit comments

Comments
 (0)