Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow compile times due to compiler issue #114

Open
kettle11 opened this issue Aug 7, 2020 · 1 comment
Open

Slow compile times due to compiler issue #114

kettle11 opened this issue Aug 7, 2020 · 1 comment

Comments

@kettle11
Copy link

kettle11 commented Aug 7, 2020

This isn't directly actionable by glow, but I wanted to open an issue to draw attention to it.

I was surprised at how long glow took to compile given its complexity (~14 seconds on my machine).

I asked about it in the Rust compiler team Zulip and they diagnosed it as this issue: rust-lang/rust#65510 (Quadratic slowdown for lookup of bounds on associated types)

@matthewjasper believes this should be fixed by rust-lang/rust#73905

@kettle11 kettle11 changed the title Slow compile times due to compiler bug Slow compile times due to compiler issue Aug 7, 2020
@kettle11
Copy link
Author

kettle11 commented Oct 7, 2020

So rust-lang/rust#73905 was merged and I decided to see how it impacts glow compile times.

Clean build times of glow on stable: ~15.3 seconds
Clean build times of glow on nightly: ~3.6 seconds

This is a fantastic improvement! :)

Thanks @matthewjasper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant