typing error in React

[chungwong]

removeWidget takes type GridStackElement = string | HTMLElement | GridItemHTMLElement

public removeWidget(els: GridStackElement, removeDOM = true, triggerEvent = true): GridStack {..}

And the react version is violating the above

  removeWidget: (id: string) => void;

This triggered a chain of changes and there is on concern with one of the changes,

<GridStackWidgetContext.Provider key={id} value={{ widget: { id } }} />

Note key={id} here, id is GridStackElement which it could be a HTMLElement and I don't think it is ideal to pass HTMLElement as the key.

[adumesny]

@Aysnine

[Aysnine]

Thanks for the issue. this is indeed an issue, the react wrapper development is still ongoing, you can try the latest wrapper here in the interim. the latest wrapper doesn't use removeWidget(id) any more. And more streamlined and combinable

[adumesny]

@Aysnine can you do your work/changes in our /react folder instead ? I know you have that review pending - we can always check it in an iterate. I just want all the work in gridstack and release an official wrapper that matches what I did for Angular.

[Aysnine]

@adumesny ok. I'm in the process of adapting setupDragIn, and the save/load example. when I'm done with these two I'll open the pr