Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of host.TrafficKeyPublic[0:32] as AES-GCM Key #3360

Open
s0metea opened this issue Mar 10, 2025 · 0 comments
Open

Use of host.TrafficKeyPublic[0:32] as AES-GCM Key #3360

s0metea opened this issue Mar 10, 2025 · 0 comments

Comments

@s0metea
Copy link

s0metea commented Mar 10, 2025

In migrate.go and util.go, the following approach is used for symmetric encryption:

encrypted, encryptErr = encryptAESGCM(host.TrafficKeyPublic[0:32], zipped)

Here, host.TrafficKeyPublic[0:32] is used as the encryption key.

Questions:
1. Is this intentional?
2. Shouldn’t the encryption key be randomly generated and then encrypted asymmetrically using TrafficKeyPublic?
3. What is the rationale behind this design choice?

If this is by design, can you clarify the reasoning and security implications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant