Skip to content

Commit 95659ef

Browse files
authored
Create CONTRIBUTING.md
1 parent f3a4243 commit 95659ef

File tree

1 file changed

+71
-0
lines changed

1 file changed

+71
-0
lines changed

CONTRIBUTING.md

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
# How to contribute to Netmaker
2+
3+
Hey! We're glad you're here. We need your help making Netmaker as great as it can be.
4+
5+
If you haven't already, come chat with us in [Discord](https://discord.gg/zRb9Vfhk8A). We can help you find the right thing to work on.
6+
7+
Before you start contributing, take a moment to check here if it makes sense.
8+
9+
#### **Did you find a bug?**
10+
11+
* Search on on GitHub under [Issues](https://github.com/gravitl/netmaker/issues) to make sure the bug was not already discovered.
12+
13+
* If you don't find an open issue that addresses the problem, you can [open a new one](https://github.com/gravitl/netmaker/issues/new).
14+
15+
* If you're creating a new issue, include a **title and clear description**, as much relevant information as possible **including logs**, and an explanation/output demonstrating expected behavior vs. actual behavior. Make sure to specify the **version of netmaker/netclient.** If it's a server issue, describe the environment where the server is running. If it's a client issue, give us the operating system and any relevant environment factors (CGNAT, 4g router, etc).
16+
17+
* Respond to team queries in a timely manner, since stale issues will be closed.
18+
19+
#### **Did you write a patch that fixes a bug?**
20+
21+
* Open a new GitHub pull request with the patch **against the 'develop' branch**.
22+
23+
* The PR should clearly describe the problem and solution. Include an issue number if possible.
24+
25+
* Make sure to add comments for any new functions
26+
27+
#### **Did you fix whitespace, format code, or make a purely cosmetic patch?**
28+
29+
Cosmetic changes that do not add substantial useability, stability, functionality, or testability to the code base will not be accepted. The calculation is simple. If it will take more time to merge and test than it took you to make and submit the code, it is likely not worthwhile (execptions exist of course for critical errors with easy fixes).
30+
31+
#### **Do you want to add a new feature to Netmaker?**
32+
33+
* Once again, join the [Discord](https://discord.gg/zRb9Vfhk8A)! Bring it up there and we can discuss. Even if you do not know what you want to build, but you want to build something, we can help you choose something from the roadmap.
34+
35+
#### **Do you want to contribute to Netmaker documentation?**
36+
37+
* Make sure your documentation compiles correctly
38+
39+
* You will need [sphinx](https://www.sphinx-doc.org/en/master/usage/installation.html) and the [material theme](https://github.com/bashtage/sphinx-material/) to run the documentation locally.
40+
41+
* Once the above plugins are installed, you can navigate to the **docs** directory and run **make html**
42+
43+
* View the compiled files (start with index.html under _build) in your browser and make sure your changes look correct before submitting.
44+
45+
46+
## Submitting Changes
47+
48+
* Please label your branch using our convention: **purpose_version_thing-you-did**. Purpose is either feature, bugfix, or hotfix.
49+
50+
* Examples: feature_v0.9.5_widget, bugfix_v0.8.2_ipv6-changes
51+
52+
* Please open a [Pull Request](https://github.com/gravitl/netmaker/compare/develop...master?expand=1) against the develop branch with your branch which clearly describes everything you've done and references any related GitHub issues.
53+
54+
* You will need to sign the CLA in order for us to accept your changes (a bot should appear asking you to sign)
55+
56+
* Please respond to any feedback in a timely manner. Stale PR's will be closed periodically.
57+
58+
## Coding conventions
59+
60+
Take a look around the code to get a feel for how we're doing things.
61+
62+
* Use private functions where possible
63+
* Use the custom loggers for log messages
64+
* Comment any new public functions
65+
66+
67+
68+
69+
## Thanks for taking the time to read this! You're awesome, and we look forward to working with you!
70+
71+
-The Netmaker Team

0 commit comments

Comments
 (0)