Merge pull request #15 from graphql-python/feat-query-by-id

Feature: Query by relay global id

Author: abawchen

graphene_mongo/fields.py

@@ -66,7 +66,8 @@ def args(self, args):
     @property
     def default_filter_args(self):
         def is_filterable(kv):
-            return hasattr(kv[1], '_type') and hasattr(kv[1]._type, '_of_type')
+            return hasattr(kv[1], '_type') \
+                    and callable(getattr(kv[1]._type, '_of_type', None))
 
         return reduce(
             lambda r, kv: r.update({kv[0]: kv[1]._type._of_type()}) or r if is_filterable(kv) else r,

graphene_mongo/tests/fixtures.py

@@ -17,7 +17,7 @@ def setup_fixtures():
     article2.save()
 
     Reporter.drop_collection()
-    reporter = Reporter(first_name='Allen', last_name='Iverson',
+    reporter = Reporter(id='1', first_name='Allen', last_name='Iverson',
                         email='[email protected]',  awards=['2010-mvp'])
     reporter.articles = [article1, article2]
     embedded_article1 = EmbeddedArticle(

graphene_mongo/tests/models.py

@@ -45,6 +45,7 @@ class EmbeddedArticle(EmbeddedDocument):
 class Reporter(Document):
     meta = {'collection': 'test_repoter'}
 
+    id = StringField(primary_key=True)
     first_name = StringField(required=True)
     last_name = StringField(required=True)
     email = EmailField()

graphene_mongo/tests/test_relay_query.py

@@ -189,7 +189,7 @@ class Mutation(graphene.ObjectType):
     schema = graphene.Schema(query=Query, mutation=Mutation)
     result = schema.execute(query)
     assert not result.errors
-    # assert result.data == expected
+    assert result.data == expected
 
 def test_should_filter():
 
@@ -231,6 +231,32 @@ class Query(graphene.ObjectType):
     assert result.data == expected
 
 
+def test_should_get_node_by_id():
+    # Notes: https://goo.gl/hMNRgs
+    class Query(graphene.ObjectType):
+        reporter = Node.Field(ReporterNode)
+        reporters = MongoengineConnectionField(ReporterNode)
+
+    query = '''
+        query ReportersQuery {
+            reporter (id: "UmVwb3J0ZXJOb2RlOjE=") {
+                id,
+                firstName
+            }
+        }
+    '''
+    expected = {
+        'reporter': {
+            'id': 'UmVwb3J0ZXJOb2RlOjE=',
+            'firstName': 'Allen'
+        }
+    }
+    schema = graphene.Schema(query=Query)
+    result = schema.execute(query)
+    assert not result.errors
+    assert result.data == expected
+
+
 def test_should_first_n():
 
     class Query(graphene.ObjectType):

graphene_mongo/types.py

@@ -127,10 +127,9 @@ def is_type_of(cls, root, info):
             ).format(root))
         return isinstance(root, cls._meta.model)
 
-    # noqa
     @classmethod
-    def get_node(cls, id, context, info):
-        return cls._meta.model.get(id)
+    def get_node(cls, info, id):
+        return cls._meta.model.objects.get(pk=id)
 
     def resolve_id(self, info):
         return str(self.id)