Skip to content

Commit 70a1410

Browse files
committed
Remove unused test dependencies and redundant compiler properties
Nothing uses cglib-nodep or objenesis. The release option already sets the source and target, so it now reads java.version too. The surefire-junit4 provider stays, with a comment on why.
1 parent 310bc0c commit 70a1410

1 file changed

Lines changed: 2 additions & 23 deletions

File tree

‎pom.xml‎

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
<graphql-java.version>26.1</graphql-java.version>
2121
<reactive-streams.version>1.0.4</reactive-streams.version>
2222

23-
<maven.compiler.source>${java.version}</maven.compiler.source>
24-
<maven.compiler.target>${java.version}</maven.compiler.target>
2523
<useReleaseProfile>false</useReleaseProfile>
2624
<project.scm.id>github</project.scm.id>
2725
</properties>
@@ -86,11 +84,6 @@
8684
</dependency>
8785

8886
<!-- Test -->
89-
<dependency>
90-
<groupId>cglib</groupId>
91-
<artifactId>cglib-nodep</artifactId>
92-
<version>3.3.0</version>
93-
</dependency>
9487
<dependency>
9588
<groupId>ch.qos.logback</groupId>
9689
<artifactId>logback-classic</artifactId>
@@ -106,11 +99,6 @@
10699
<artifactId>junit</artifactId>
107100
<version>4.13.2</version>
108101
</dependency>
109-
<dependency>
110-
<groupId>org.objenesis</groupId>
111-
<artifactId>objenesis</artifactId>
112-
<version>3.6</version>
113-
</dependency>
114102
<dependency>
115103
<groupId>org.reactivestreams</groupId>
116104
<artifactId>reactive-streams-tck</artifactId>
@@ -202,16 +190,6 @@
202190
<artifactId>junit</artifactId>
203191
<scope>test</scope>
204192
</dependency>
205-
<dependency>
206-
<groupId>cglib</groupId>
207-
<artifactId>cglib-nodep</artifactId>
208-
<scope>test</scope>
209-
</dependency>
210-
<dependency>
211-
<groupId>org.objenesis</groupId>
212-
<artifactId>objenesis</artifactId>
213-
<scope>test</scope>
214-
</dependency>
215193
<dependency>
216194
<groupId>org.reactivestreams</groupId>
217195
<artifactId>reactive-streams-tck</artifactId>
@@ -247,7 +225,7 @@
247225
<artifactId>maven-compiler-plugin</artifactId>
248226
<version>3.16.0</version>
249227
<configuration>
250-
<release>17</release>
228+
<release>${java.version}</release>
251229
<failOnWarning>true</failOnWarning>
252230
</configuration>
253231
</plugin>
@@ -257,6 +235,7 @@
257235
<artifactId>maven-surefire-plugin</artifactId>
258236
<version>3.6.0</version>
259237
<dependencies>
238+
<!-- reactive-streams-tck brings TestNG, which makes surefire pick a provider that runs none of the JUnit 4 tests -->
260239
<dependency>
261240
<groupId>org.apache.maven.surefire</groupId>
262241
<artifactId>surefire-junit4</artifactId>

0 commit comments

Comments
 (0)