-
Notifications
You must be signed in to change notification settings - Fork 25
Better OTEL default resources and Hive Tracing improvements #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @enisdenjo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the OpenTelemetry integration by centralizing resource creation logic and establishing more sensible default values for service names and versions. It also strengthens the configuration validation for Hive Tracing processors, ensuring essential parameters like access tokens and endpoints are correctly provided. These changes aim to make the observability setup more robust, consistent, and user-friendly. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several improvements to the OpenTelemetry integration. It sets more sensible defaults for the service name and version in OTEL resources, using hive-gateway and the gateway's version respectively. The hiveTracingSetup function has been significantly refactored for better clarity and robustness, especially in how it configures the Hive tracing processor.
My review focuses on the new createResource function. While the refactoring is a good step, I've identified a potential bug in how it handles an explicitly undefined serviceVersion and have suggested a cleaner implementation that fixes this issue and improves readability.
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/gateway |
2.1.19-alpha-1bfda770fe8ac08e452e19fceb9f1e162148ae75 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
2.0.24-alpha-1bfda770fe8ac08e452e19fceb9f1e162148ae75 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-opentelemetry |
1.2.1-alpha-1bfda770fe8ac08e452e19fceb9f1e162148ae75 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
2.1.5-alpha-1bfda770fe8ac08e452e19fceb9f1e162148ae75 |
npm ↗︎ unpkg ↗︎ |
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
Closes #1540, closes #1552
hive-gatewayas the default service namehive.otel.version)https://api.graphql-hive.com/otel/v1/tracesas the default endpoint for hive tracingBonus
Reduced flakiness of Cloudflare E2E tests and clarify errors.