federation bug plz

Author: aexol

Diff for: src/TreeOperations/merge/arguments.ts

@@ -24,6 +24,7 @@ export const mergeArguments = (parentName: string, args1: ParserField[], args2:
       if (!equivalentA2) return;
       if (a1.type.fieldType.type === Options.required) return a1;
       if (equivalentA2.type.fieldType.type === Options.required) return equivalentA2;
+      if (a1.type.fieldType.type === equivalentA2.type.fieldType.type) return a1;
     })
     .filter(<T>(v: T | undefined): v is T => !!v);
 };

Diff for: src/__tests__/TreeOperations/merge/merge.input.spec.ts

@@ -26,6 +26,33 @@ describe('Merging GraphQL Inputs and field arguments', () => {
       }`,
     );
   });
+  it('Should merge inputs leaving common fields both required and not', () => {
+    const baseSchema = `
+    input UserInput {
+      name: String!
+      list: Boolean
+      age: Int # Not in Subgraph B
+    }
+    `;
+
+    const mergingSchema = `
+    input UserInput {
+      name: String!
+      list: Boolean
+      email: String # Not in Subgraph A
+    }
+    `;
+    const t1 = mergeSDLs(baseSchema, mergingSchema);
+    if (t1.__typename === 'error') throw new Error('Invalid parse');
+    expectTrimmedEqual(
+      t1.sdl,
+      `
+      input UserInput{
+        name: String!
+        list: Boolean
+      }`,
+    );
+  });
   it('Should merge inputs marking fields required.', () => {
     const baseSchema = `
     input UserInput {