Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error codes for tap receipt failure #211

Open
gusinacio opened this issue Jun 18, 2024 · 0 comments
Open

Better error codes for tap receipt failure #211

gusinacio opened this issue Jun 18, 2024 · 0 comments
Labels
p2 Medium priority pgk:service repo:indexer-rs type:feature New or enhanced functionality type:spike Additional research required

Comments

@gusinacio
Copy link
Member

gusinacio commented Jun 18, 2024

Problem statement
Indexer service is not sending any useful information detailing the error. This is due to security reasons but there are some information that could be exposed like payment status, so the sender can handle the error and deposit more tokens to the escrow.

We already have good status code for general errors, but we still need error codes to signalize the different error codes in case the sender is denied and what's the reason so the sender knows what to do.

@gusinacio gusinacio added p2 Medium priority type:spike Additional research required labels Sep 20, 2024
@gusinacio gusinacio added pgk:service repo:indexer-rs type:feature New or enhanced functionality labels Oct 17, 2024 — with Linear
@gusinacio gusinacio changed the title [Feat.Req] Better error codes for indexer-service Better error codes for indexer-service Oct 17, 2024
@shiyasmohd shiyasmohd assigned shiyasmohd and unassigned shiyasmohd Oct 23, 2024
@gusinacio gusinacio self-assigned this Nov 28, 2024
@gusinacio gusinacio changed the title Better error codes for indexer-service Better error codes for tap receipt failure Nov 28, 2024
@gusinacio gusinacio removed their assignment Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Medium priority pgk:service repo:indexer-rs type:feature New or enhanced functionality type:spike Additional research required
Projects
None yet
Development

No branches or pull requests

2 participants