Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace axios with fetch global function #76

Open
grantholle opened this issue Sep 13, 2023 · 2 comments
Open

Replace axios with fetch global function #76

grantholle opened this issue Sep 13, 2023 · 2 comments

Comments

@grantholle
Copy link
Owner

Fetch was added to node v18 without the experimental flag. Deno and Bun both have support for it, so it makes the most sense to refactor to use fetch and release a new major version with v18 of node being the minimum version.

@chadacious
Copy link
Contributor

We have been encountering problems with either axios itself or perhaps it's the request queuing system when running this library in a bun app. There are a lot of intermittent failures where requests just aren't returning. Don't know yet if the queue system is dropping them or if it's an axios thing for not returning anything for some requests.

Have you started work on this refactor at all yet? We didn't notice these issues until we went live with so we are looking at this now.

@grantholle
Copy link
Owner Author

I would imagine that it would be Bun + axios but I'm not sure.

I am a bit swamped right now but I don't imagine it would take too much. I'll try to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants