Adding PostgreSQL 16/17 Support #2
Description
Fail to build against PostgreSQL 16/17
$ rpmbuild --with debuginfo --define "pgmajorversion 16" -ba ~/rpmbuild/SPECS/pg_zstd.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.Jhztfj
+ umask 022
+ cd /home/vagrant/rpmbuild/BUILD
+ cd /home/vagrant/rpmbuild/BUILD
+ rm -rf pgzstd-1.1.2
+ /usr/bin/gzip -dc /home/vagrant/rpmbuild/SOURCES/pgzstd-1.1.2.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd pgzstd-1.1.2
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.08bceo
+ umask 022
+ cd /home/vagrant/rpmbuild/BUILD
+ cd pgzstd-1.1.2
+ PATH=/usr/pgsql-16/bin:/home/vagrant/.cargo/bin:/home/vagrant/.local/bin:/home/vagrant/bin:/usr/share/Modules/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
+ /usr/bin/make -j10
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -fvisibility=hidden -I. -I./ -I/usr/pgsql-16/include/server -I/usr/pgsql-16/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -c -o zstd.o zstd.c
/usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -O2 -I. -I./ -I/usr/pgsql-16/include/server -I/usr/pgsql-16/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -flto=thin -emit-llvm -c -o zstd.bc zstd.c
zstd.c: In function 'compress':
zstd.c:56:14: warning: implicit declaration of function 'VARSIZE' [-Wimplicit-function-declaration]
in_len = VARSIZE(in) - VARHDRSZ;
^~~~~~~
zstd.c:63:16: warning: implicit declaration of function 'VARDATA'; did you mean 'ENODATA'? [-Wimplicit-function-declaration]
dict = VARDATA(d);
^~~~~~~
ENODATA
zstd.c:63:14: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
dict = VARDATA(d);
^
zstd.c:70:45: warning: passing argument 2 of 'ZSTD_compress_usingDict' makes pointer from integer without a cast [-Wint-conversion]
out_len = ZSTD_compress_usingDict(cctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len, level);
^~~~~~~~~~~~
In file included from zstd.c:3:
/usr/include/zstd.h:788:50: note: expected 'void *' but argument is of type 'int'
void* dst, size_t dstCapacity,
~~~~~~^~~
zstd.c:70:68: warning: passing argument 4 of 'ZSTD_compress_usingDict' makes pointer from integer without a cast [-Wint-conversion]
out_len = ZSTD_compress_usingDict(cctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len, level);
^~~~~~~~~~~
In file included from zstd.c:3:
/usr/include/zstd.h:789:50: note: expected 'const void *' but argument is of type 'int'
const void* src, size_t srcSize,
~~~~~~~~~~~~^~~
zstd.c:77:5: warning: implicit declaration of function 'SET_VARSIZE' [-Wimplicit-function-declaration]
SET_VARSIZE(out, out_len + VARHDRSZ);
^~~~~~~~~~~
zstd.c: In function 'decompress':
zstd.c:97:14: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
dict = VARDATA(d);
^
zstd.c:102:40: warning: passing argument 1 of 'ZSTD_getFrameContentSize' makes pointer from integer without a cast [-Wint-conversion]
out_len = ZSTD_getFrameContentSize(VARDATA(in), in_len);
^~~~~~~~~~~
In file included from zstd.c:3:
/usr/include/zstd.h:154:69: note: expected 'const void *' but argument is of type 'int'
ZSTDLIB_API unsigned long long ZSTD_getFrameContentSize(const void *src, size_t srcSize);
~~~~~~~~~~~~^~~
zstd.c:112:47: warning: passing argument 2 of 'ZSTD_decompress_usingDict' makes pointer from integer without a cast [-Wint-conversion]
out_len = ZSTD_decompress_usingDict(dctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len);
^~~~~~~~~~~~
In file included from zstd.c:3:
/usr/include/zstd.h:800:52: note: expected 'void *' but argument is of type 'int'
void* dst, size_t dstCapacity,
~~~~~~^~~
zstd.c:112:70: warning: passing argument 4 of 'ZSTD_decompress_usingDict' makes pointer from integer without a cast [-Wint-conversion]
out_len = ZSTD_decompress_usingDict(dctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len);
^~~~~~~~~~~
In file included from zstd.c:3:
/usr/include/zstd.h:801:52: note: expected 'const void *' but argument is of type 'int'
const void* src, size_t srcSize,
~~~~~~~~~~~~^~~
zstd.c: In function 'length':
zstd.c:134:40: warning: passing argument 1 of 'ZSTD_getFrameContentSize' makes pointer from integer without a cast [-Wint-conversion]
out_len = ZSTD_getFrameContentSize(VARDATA(in), in_len);
^~~~~~~~~~~
In file included from zstd.c:3:
/usr/include/zstd.h:154:69: note: expected 'const void *' but argument is of type 'int'
ZSTDLIB_API unsigned long long ZSTD_getFrameContentSize(const void *src, size_t srcSize);
~~~~~~~~~~~~^~~
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -fvisibility=hidden -shared -o zstd.so zstd.o -L/usr/pgsql-16/lib -Wl,--as-needed -L/usr/lib64 -L/usr/lib -L/usr/lib64 -Wl,--as-needed -Wl,-rpath,'/usr/pgsql-16/lib',--enable-new-dtags -fvisibility=hidden -lzstd
zstd.c:56:14: error: call to undeclared function 'VARSIZE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
56 | in_len = VARSIZE(in) - VARHDRSZ;
| ^
zstd.c:63:16: error: call to undeclared function 'VARDATA'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
63 | dict = VARDATA(d);
| ^
zstd.c:63:14: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion]
63 | dict = VARDATA(d);
| ^ ~~~~~~~~~~
zstd.c:70:45: error: call to undeclared function 'VARDATA'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
70 | out_len = ZSTD_compress_usingDict(cctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len, level);
| ^
zstd.c:70:45: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'void *' [-Wint-conversion]
70 | out_len = ZSTD_compress_usingDict(cctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len, level);
| ^~~~~~~~~~~~
/usr/include/zstd.h:788:50: note: passing argument to parameter 'dst' here
788 | void* dst, size_t dstCapacity,
| ^
zstd.c:70:68: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *' [-Wint-conversion]
70 | out_len = ZSTD_compress_usingDict(cctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len, level);
| ^~~~~~~~~~~
/usr/include/zstd.h:789:50: note: passing argument to parameter 'src' here
789 | const void* src, size_t srcSize,
| ^
zstd.c:77:5: error: call to undeclared function 'SET_VARSIZE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
77 | SET_VARSIZE(out, out_len + VARHDRSZ);
| ^
zstd.c:92:14: error: call to undeclared function 'VARSIZE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
92 | in_len = VARSIZE(in) - VARHDRSZ;
| ^
zstd.c:97:16: error: call to undeclared function 'VARDATA'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
97 | dict = VARDATA(d);
| ^
zstd.c:97:14: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion]
97 | dict = VARDATA(d);
| ^ ~~~~~~~~~~
zstd.c:102:40: error: call to undeclared function 'VARDATA'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
102 | out_len = ZSTD_getFrameContentSize(VARDATA(in), in_len);
| ^
zstd.c:102:40: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *' [-Wint-conversion]
102 | out_len = ZSTD_getFrameContentSize(VARDATA(in), in_len);
| ^~~~~~~~~~~
/usr/include/zstd.h:154:69: note: passing argument to parameter 'src' here
154 | ZSTDLIB_API unsigned long long ZSTD_getFrameContentSize(const void *src, size_t srcSize);
| ^
zstd.c:112:47: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'void *' [-Wint-conversion]
112 | out_len = ZSTD_decompress_usingDict(dctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len);
| ^~~~~~~~~~~~
/usr/include/zstd.h:800:52: note: passing argument to parameter 'dst' here
800 | void* dst, size_t dstCapacity,
| ^
zstd.c:112:70: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *' [-Wint-conversion]
112 | out_len = ZSTD_decompress_usingDict(dctx, VARDATA(out), out_len, VARDATA(in), in_len, dict, dict_len);
| ^~~~~~~~~~~
/usr/include/zstd.h:801:52: note: passing argument to parameter 'src' here
801 | const void* src, size_t srcSize,
| ^
zstd.c:117:5: error: call to undeclared function 'SET_VARSIZE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
117 | SET_VARSIZE(out, out_len + VARHDRSZ);
| ^
zstd.c:131:14: error: call to undeclared function 'VARSIZE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
131 | in_len = VARSIZE(in) - VARHDRSZ;
| ^
zstd.c:134:40: error: call to undeclared function 'VARDATA'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
134 | out_len = ZSTD_getFrameContentSize(VARDATA(in), in_len);
| ^
zstd.c:134:40: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'const void *' [-Wint-conversion]
134 | out_len = ZSTD_getFrameContentSize(VARDATA(in), in_len);
| ^~~~~~~~~~~
/usr/include/zstd.h:154:69: note: passing argument to parameter 'src' here
154 | ZSTDLIB_API unsigned long long ZSTD_getFrameContentSize(const void *src, size_t srcSize);
| ^
18 errors generated.
make: *** [/usr/pgsql-16/lib/pgxs/src/makefiles/../../src/Makefile.global:1093: zstd.bc] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.08bceo (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.08bceo (%build)