Merge pull request #175 from grafana/cleanup

fix: Minor QoL clean up

Author: bryanhuhta

Diff for: .gitignore

@@ -1,4 +1,5 @@
 /.idea/
+/.vscode/
 
 # Ignore Gradle project-specific cache directory
 .gradle

Diff for: agent/src/main/java/io/pyroscope/javaagent/impl/PyroscopeExporter.java

@@ -1,6 +1,5 @@
 package io.pyroscope.javaagent.impl;
 
-import io.pyroscope.http.Format;
 import io.pyroscope.javaagent.EventType;
 import io.pyroscope.javaagent.Snapshot;
 import io.pyroscope.javaagent.api.Exporter;

Diff for: async-profiler-context/src/main/java/io/pyroscope/labels/Ref.java

@@ -16,7 +16,8 @@ public Ref(T val, Long id) {
     public boolean equals(Object o) {
         if (this == o) return true;
         if (o == null || getClass() != o.getClass()) return false;
-        Ref<T> valueRef = (Ref<T>) o;
+
+        Ref<?> valueRef = (Ref<?>) o;
         return id.equals(valueRef.id);
     }
 

Diff for: async-profiler-context/src/main/java/io/pyroscope/labels/io/pyroscope/PyroscopeAsyncProfiler.java

@@ -2,20 +2,14 @@
 
 import one.profiler.AsyncProfiler;
 
-import java.io.BufferedReader;
-import java.io.File;
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
-import java.io.InputStreamReader;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.nio.file.StandardCopyOption;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
 
 public class PyroscopeAsyncProfiler {
     static final String libraryPath;

Diff for: async-profiler-context/src/test/java/io/pyroscope/labels/LabelsTest.java

@@ -225,7 +225,7 @@ void stressTest() throws InterruptedException {
         }
         e.shutdown();
         e.awaitTermination(100, TimeUnit.SECONDS);
-        Snapshot res = Pyroscope.LabelsWrapper.dump();
+        Pyroscope.LabelsWrapper.dump();
         assertEquals(0, ScopedContext.context.get().id);
         assertEquals(0, RefCounted.strings.valueToRef.size());
         assertEquals(0, RefCounted.contexts.valueToRef.size());

Diff for: async-profiler-context/src/test/java/io/pyroscope/labels/RefTest.java

@@ -0,0 +1,33 @@
+package io.pyroscope.labels;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class RefTest {
+    @Test
+    void testCreateRef() {
+        Ref<String> ref = new Ref<>("test", 1L);
+        assertEquals("test", ref.val);
+        assertEquals(1L, ref.id);
+        assertEquals(1L, ref.refCount.get());
+    }
+
+    @Test
+    @SuppressWarnings("unlikely-arg-type")
+    void testEquals() {
+        Ref<String> ref1 = new Ref<>("test", 1L);
+        assertTrue(ref1.equals(ref1));
+        assertFalse(ref1.equals(null));
+        assertFalse(ref1.equals(new Integer(3)));
+        assertTrue(ref1.equals(new Ref<Integer>(3, 1L))); // We don't compare the value types.
+    }
+
+    @Test
+    void testHashCode() {
+        Ref<String> ref1 = new Ref<>("test", 1L);
+        assertEquals(1, ref1.hashCode());
+    }
+}

Diff for: demo/src/main/java/Fib.java

@@ -1,6 +1,4 @@
 
-import java.util.HashMap;
-import java.util.Map;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;