Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include position information in annotations returned from sharded queries #9141

Open
charleskorn opened this issue Aug 30, 2024 · 0 comments

Comments

@charleskorn
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If a query is sharded and returns annotations, the annotations do not include position information.

For example, running the query sum(rate(foo[1m])) without sharding returns the annotation metric might not be a counter, name does not end in _total/_sum/_count/_bucket: "foo" (1:10), where the (1:10) refers to the position in the expression that the annotation relates to.

However, if the same query is run without sharding, then the annotation does not include position information. This can make it harder to understand what the annotation is referring to.

Describe the solution you'd like

Include position information in annotations returned for sharded queries.

Describe alternatives you've considered

(none)

Additional context

Discussed further here: #9138 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant