Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding podLabels in global section breaking parsing #9046

Open
kunalmehta-eve opened this issue Aug 19, 2024 · 1 comment
Open

Adding podLabels in global section breaking parsing #9046

kunalmehta-eve opened this issue Aug 19, 2024 · 1 comment
Labels
helm question Further information is requested

Comments

@kunalmehta-eve
Copy link

Describe the bug

Adding podLabels in global section breaking parsing

global:
podLabels:
azure.workload.identity/use: "true"

YAML parse error on mimir-distributed/templates/compactor/compactor-statefulset.yaml: error converting YAML to JSON: yaml: line 38: did not find expected key

To Reproduce

Steps to reproduce the behavior:

  1. Start Mimir (SHA or version)
  2. Perform Operations(Read/Write/Others)

Expected behavior

A clear and concise description of what you expected to happen.

Environment

  • Infrastructure: Kubernetes
  • Deployment tool: helm

Additional Context

@narqo narqo added question Further information is requested helm labels Aug 19, 2024
@narqo
Copy link
Contributor

narqo commented Aug 19, 2024

From a quick look, I couldn't reproduce it with the provided values (see 9046-helm-values.yaml below).

% cat 9046-helm-values.yaml
global:
  podLabels:
    azure.workload.identity/use: "true"

% helm template test-mimir . -f 9046-helm-values.yaml
···
# Source: mimir-distributed/templates/compactor/compactor-statefulset.yaml
apiVersion: apps/v1
kind: StatefulSet
···
spec:
  template:
    metadata:
      labels:
        azure.workload.identity/use: "true"
        helm.sh/chart: mimir-distributed-5.5.0-weekly.304
        app.kubernetes.io/name: mimir
        app.kubernetes.io/instance: test-mimir
        app.kubernetes.io/version: "r304"
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/component: compactor
        app.kubernetes.io/part-of: memberlist

@kunalmehta-eve could you fill up the missing details:

  • What version of Mimir you're using
  • What do you feed in with the helm's values
  • Something else to reproduce the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants