Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimirtool backfill - compactor: can't check block state/block validation failed #9032

Open
litetex opened this issue Aug 17, 2024 · 1 comment

Comments

@litetex
Copy link

litetex commented Aug 17, 2024

Describe the bug

When running mimirtool backfill I get caller=block_upload.go:207 level=warn component=compactor user=tdr feature="block upload" block=01J4WNXPS4GSR8AMK9A4732704 operation="start block upload" request_id=17ec82ff283a34ff msg="can't check block state" response="block validation failed" status=400

Setting the log level to debug doesn't help at all.

It would be nice to know WHY the validation failed so that I can diagnose and address the problem...

To Reproduce

Sorry but I can't paste my complete setup here.

Basically:

  1. Start mimir
  2. Run backfill for prometheus:
    mimirtool backfill --address=http://mimir-backend:9009 --id=<redacted> /data/prometheus/01J4WNXPS4GSR8AMK9A4732704 ...

Expected behavior

See an error message that says what caused the block validation error so that I can fix it.

Environment

irrelevant
Mimir version: 2.13.0

Additional Context

Same problem was already encountered in #8164 but no efforts were made to improve the situation :/

Likely these pieces of code should rethrow the error and not just "swallow" it:

if v.Error != "" {
return blockValidationFailed, meta, v, err
}

case blockValidationFailed:
return m, v, httpError{message: "block validation failed", statusCode: http.StatusBadRequest}
}

@litetex
Copy link
Author

litetex commented Aug 17, 2024

Also note that compactor_block_upload_validation_enabled: false doesn't help... The error is still the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant