Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer possible to add labels to all loki created objects in kubernetes with the new helm chart. #8819

Open
rubenvw-ngdata opened this issue Mar 16, 2023 · 1 comment

Comments

@rubenvw-ngdata
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The problem is that we used to set labels on all deployed kubernetes objects (services, service accounts, etc) with the loki helm chart v 2.16.0, but after migrating to 4.8.0 this is no longer possible. We use these labels to label all objects that are part of the deployment for the same environment.

Describe the solution you'd like
It would be interesting if we could add some general labels everywhere where the template uses include "loki.labels". e.g. by adding Values.loki.genericLabels. Now it is only possible to add labels to pods with Values.loki.podLabels.

Describe alternatives you've considered
As an alternative I could add the labels with kubectl command after the deployment, but that would complicate the loki deployment.

Additional context
Not required, should be clear with the description.

@Rohlik
Copy link

Rohlik commented Sep 17, 2024

It's very much the same issue as for Mimir - grafana/mimir#9067.
I would love to see this implemented and not do some workarounds instead 😔.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants