From a4aef8a81ea79c4532a41213a1af30a366d47848 Mon Sep 17 00:00:00 2001
From: Lane <26094878+laneme@users.noreply.github.com>
Date: Mon, 10 Aug 2020 07:14:41 +0600
Subject: [PATCH] removing repeated if staements from user.js

---
 routes/api/users.js | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/routes/api/users.js b/routes/api/users.js
index cc2e444c5..7afb212c1 100644
--- a/routes/api/users.js
+++ b/routes/api/users.js
@@ -16,19 +16,16 @@ router.put('/user', auth.required, function(req, res, next){
   User.findById(req.payload.id).then(function(user){
     if(!user){ return res.sendStatus(401); }
 
+    // allowed fields in request body (excluding password)
+    const fields = ['username', 'email', 'bio', 'image']
+    
     // only update fields that were actually passed...
-    if(typeof req.body.user.username !== 'undefined'){
-      user.username = req.body.user.username;
-    }
-    if(typeof req.body.user.email !== 'undefined'){
-      user.email = req.body.user.email;
-    }
-    if(typeof req.body.user.bio !== 'undefined'){
-      user.bio = req.body.user.bio;
-    }
-    if(typeof req.body.user.image !== 'undefined'){
-      user.image = req.body.user.image;
-    }
+    fields.forEach(prop => {
+      if (req.body.user[prop] !== undefined) {
+        user[prop] = req.body.user[prop]
+      }
+    })
+    
     if(typeof req.body.user.password !== 'undefined'){
       user.setPassword(req.body.user.password);
     }