Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDL Incorrectly disallows some characters in instance name #1568

Open
2 tasks done
ScottKillen opened this issue May 13, 2023 · 0 comments
Open
2 tasks done

GDL Incorrectly disallows some characters in instance name #1568

ScottKillen opened this issue May 13, 2023 · 0 comments
Labels
Type: Bug Non fatal problems who can be ignored/worked around

Comments

@ScottKillen
Copy link

  • I searched the issue tracker for other issues covering my case
  • This is a Launcher issue.

Describe the bug
If I create an instance, GDL will not allow the name to include brackets and parenthesis; however, I can rename my folder outside of GDL, and GDL picks up on the instance even though it includes these 'illegal' characters.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new instance using the Better MC [FABRIC] - BMC 1 from Curseforge.
  2. Type Better MC [FABRIC] - BMC 1 for the instance name
  3. Notice the error message saying that the instance name is not valid.
  4. Clear the instance name field to allow the instance to use the default name.
  5. Create the instance.
  6. Close GDL.
  7. Rename the instance folder with the name that includes the 'illegal' characters.
  8. Notice that the instance's name is the same as what you were not allowed to type in GDL.

Expected behavior
GDL should not disallow valid instance names.

Possible solutions
Allow GDL to determine valid instance names based on the platform it runs on.

Screenshots
image
image

Operating System:

  • OS: Windows 11
  • Launcher Version: v1.1.30
  • Java Version: N/A
  • Minecraft Version: N/A
  • Mod Loader: N/A
@Eskaan Eskaan added the Type: Bug Non fatal problems who can be ignored/worked around label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Non fatal problems who can be ignored/worked around
Development

No branches or pull requests

2 participants