fix(#2455): wrong index reported by modal + TextInput + autofocus #2456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakerwreah
commented
Sep 5, 2025
Comment on lines
+665
to
+667
| if (index === -1) { | ||
| index = DEFAULT_KEYBOARD_INDEX; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I kept this "default index" fallback, but tbh I'm not sure what is its purpose.
I'd rather have -1 instead of a "random" number if things go bad.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
not stale |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
not stale |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
not stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2455
Motivation
The new fallback logic to fix TextInput with autofocus is mixing "position" with "index", leading to corrupted behavior.
(see issue for more details)