From 398582e8634e98a4f55f65a89682d4057f09668d Mon Sep 17 00:00:00 2001 From: Martin Hoefling Date: Fri, 4 Jan 2019 22:46:51 +0100 Subject: [PATCH] fix for browser crash when jsonapi not configured, closes #104 --- tests/unit/popup.test.js | 10 +++++++--- web-extension/popup.js | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/unit/popup.test.js b/tests/unit/popup.test.js index 4f44c0c..91b40d6 100644 --- a/tests/unit/popup.test.js +++ b/tests/unit/popup.test.js @@ -104,14 +104,18 @@ describe('popup', () => { describe('logAndDisplayError', () => { test('displays message', () => { - popup.logAndDisplayError({ message: 'sample error messsage' }); + expect(() => { + popup.logAndDisplayError({ message: 'sample error messsage' }); + }).toThrow({ message: 'sample error messsage' }); expect(document.getElementsByClassName('status-text')[0].innerHTML).toBe('sample error messsage'); }); test('switches back to search', () => { - expect.assertions(3); + expect.assertions(4); return popup.switchToCreateNewDialog().then(() => { - popup.logAndDisplayError({ message: 'sample error messsage' }); + expect(() => { + popup.logAndDisplayError({ message: 'sample error messsage' }); + }).toThrow({ message: 'sample error messsage' }); expect(document.getElementsByClassName('search')[0].style.display).toBe('block'); expect(document.getElementsByClassName('results')[0].style.display).toBe('block'); expect(document.getElementsByClassName('create')[0].style.display).toBe('none'); diff --git a/web-extension/popup.js b/web-extension/popup.js index 0f8b132..cca841c 100644 --- a/web-extension/popup.js +++ b/web-extension/popup.js @@ -70,6 +70,7 @@ function logAndDisplayError(error) { console.log(error); switchToSearch(); setStatusText(error.message); + throw error; } function copyToClipboard(text) {