CameraSourcePreview doesn't fill whole screen height

[donpironet]

I'm having everything the same as in this sample except my activity layout is this:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@+id/topLayout"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:keepScreenOn="true"
    android:weightSum="100"
    android:orientation="horizontal">

    <be.citylife.communitypurchaseapp.view.camera.CameraSourcePreview
        android:id="@+id/preview"
        android:layout_width="0dp"
        android:layout_height="match_parent"
        android:layout_weight="60">

        <be.citylife.communitypurchaseapp.view.camera.GraphicOverlay
            android:id="@+id/overlay"
            android:layout_width="match_parent"
            android:layout_height="match_parent" />

    </be.citylife.communitypurchaseapp.view.camera.CameraSourcePreview>

    <FrameLayout
        android:id="@+id/sideContainer"
        android:layout_width="0dp"
        android:layout_height="match_parent"
        android:layout_weight="40"/>

</LinearLayout>

My tablet is in landscape and I want that the cameraPreviewSource is always left and fills the whole screen in the height and then right off it I'm having a fragment that fills the rest.

This layout works except my previewsource doesn't fill the whole height (even though it shows correct in the preview). It has a black banner on it. Even my width is actually smaller than I want you can see this on the screenshot:

http://i61.tinypic.com/vctmw0.png

I played with the CameraSourcePreview with the width and height in the onLayout function but it doesn't help.

Anyone an idea how to solve this?

EDIT:

I think there is a problem in the onLayout method off the CameraSourcePreview. That it doesn't calculate it right when you use maybe layout weight or something I don't know.

[pm0733464]

CameraSourcePreview is included in the example code. This was meant as more of a "Hello World" sample rather than a formal part of the API.

It has to account for getting the aspect ratio of the view to match the aspect ratio of the preview images from the camera, as well as accounting for the camera rotation. So it actually overrides the size of the view to end up with something reasonable. See here:

https://github.com/googlesamples/android-vision/blob/master/visionSamples/FaceTracker/app/src/main/java/com/google/android/gms/samples/vision/face/facetracker/ui/camera/CameraSourcePreview.java#L126

Feel free to copy/modify this class and change it to best meet your needs.

[donpironet]

Thats what I thought. The only problem I'm facing right now is that I don't know how to get the width of the screen because my layout uses layout_weight and I don't know how to get 60 % of the width. Otherwise it would be simple I guess, just retrieve the width/height or set them. Any idea or guideline how to do this?

[lucasjj85]

I'm facing the same issue, some extra padding on landscape and portrait mode.

[abhirav]

Hi,
Comment or remove below lines from CameraSourcePreview and it should be fine. I was having same issue like you and it is solved now.

if (childHeight > layoutHeight) {
    childHeight = layoutHeight;
    childWidth = (int)(((float) layoutHeight / (float) height) * width);
}

[lucasjj85]

Thank you Abhirav,
your suggestion has completely solved the issue in landscape mode (there is still a bit of padding in portrait mode but it is ok).

[donpironet]

I removed the lines to but still padding on the bottom in landscape mode. Is this some problem with layout weight?

[Kalen66100]

This is my code, no padding in portrait and fill right in landscape.

I use layoutHeight instead of childHeight in for (int i = 0; i < getChildCount(); ++i){...}

    if (mCameraSource != null)
    {
        Size size = mCameraSource.getPreviewSize();
        if (size != null)
        {
            width = size.getWidth();
            height = size.getHeight();
        }
    }

    // Swap width and height sizes when in portrait, since it will be rotated 90 degrees
    if (isPortraitMode())
    {
        int tmp = width;

        //noinspection SuspiciousNameCombination
        width = height;
        height = tmp;
    }

    final int layoutWidth = right - left;
    final int layoutHeight = bottom - top;

    // Computes height and width for potentially doing fit width.
    int childWidth = layoutWidth;
    int childHeight = (int) (((float) layoutWidth / (float) width) * height);

    for (int i = 0; i < getChildCount(); ++i)
    {
        getChildAt(i).layout(0, 0, childWidth, layoutHeight);
    }

    try
    {
        startIfReady();
    }
    catch (SecurityException se)
    {
        Log.e(TAG, "Do not have permission to start the camera", se);
    }
    catch (IOException e)
    {
        Log.e(TAG, "Could not start camera source.", e);
    }
}

[mmagician]

@abhirav Thanks, this works.

I had the same problem, unnecessary white space on the right in portrait mode.

Another thing which worked for me was removing BOTH what abhirav suggested and removing these lines:

// Computes height and width for potentially doing fit width.
int childWidth = layoutWidth;
int childHeight = (int)(((float) layoutWidth / (float) width) * height);

On the device I tested, this had no effect on how the preview actually looked, but using layoutHeight is the actual device height, whereas childHeight is computed and (in my case) bigger than device's height. But as I said, no effect on how it actually looked.

[raokarthik74]

Code suggested by mmagician and abhirav works perfectly. But, the camera preview is not in the correct ratio in portrait mode. the height is getting stretched. Could you help me out in this regard ?

[af001]

@Kalen66100
Thanks, your solution worked for me.

[carlo88doc]

Thank you @Kalen66100 , it worked for me too.

[sree973]

@Kalen66100 Thanks you. It worked for me

[romeryto]

Thank you @Kalen66100 and @abhirav . You save my code!

[pm0733464]

The following works, while also preserving the aspect ratio. This will slightly oversize the camera display, requiring cropping along one dimension. Change CameraSourcePreview.onLayout to:

    @Override
    protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
        int previewWidth = 320;
        int previewHeight = 240;
        if (mCameraSource != null) {
            Size size = mCameraSource.getPreviewSize();
            if (size != null) {
                previewWidth = size.getWidth();
                previewHeight = size.getHeight();
            }
        }

        // Swap width and height sizes when in portrait, since it will be rotated 90 degrees
        if (isPortraitMode()) {
            int tmp = previewWidth;
            previewWidth = previewHeight;
            previewHeight = tmp;
        }

        final int viewWidth = right - left;
        final int viewHeight = bottom - top;

        int childWidth;
        int childHeight;
        int childXOffset = 0;
        int childYOffset = 0;
        float widthRatio = (float) viewWidth / (float) previewWidth;
        float heightRatio = (float) viewHeight / (float) previewHeight;

        // To fill the view with the camera preview, while also preserving the correct aspect ratio,
        // it is usually necessary to slightly oversize the child and to crop off portions along one
        // of the dimensions.  We scale up based on the dimension requiring the most correction, and
        // compute a crop offset for the other dimension.
        if (widthRatio > heightRatio) {
            childWidth = viewWidth;
            childHeight = (int) ((float) previewHeight * widthRatio);
            childYOffset = (childHeight - viewHeight) / 2;
        } else {
            childWidth = (int) ((float) previewWidth * heightRatio);
            childHeight = viewHeight;
            childXOffset = (childWidth - viewWidth) / 2;
        }

        for (int i = 0; i < getChildCount(); ++i) {
            // One dimension will be cropped.  We shift child over or up by this offset and adjust
            // the size to maintain the proper aspect ratio.
            getChildAt(i).layout(
                    -1 * childXOffset, -1 * childYOffset,
                    childWidth - childXOffset, childHeight - childYOffset);
        }

        try {
            startIfReady();
        } catch (IOException e) {
            Log.e(TAG, "Could not start camera source.", e);
        }
    }