-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export types in package.json #837
Comments
If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.@Krassnig Thank you for opening this issue. 🙏
This is an automated message, feel free to ignore. |
Hi @Krassnig! Do you have an example-repo where this can be reproduced? I think a problem with the proposed solution is that it's not clear which version of the package (umd or esm) the typings are for, but I will have a look into this. |
Yes, I have set "moduleResolution": "bundler" |
Is your feature request related to a problem? Please describe.
When installing
@googlemaps/three
and importing with typescript viaimport { ThreeJSOverlayView } from '@googlemaps/three';
I get an error
Could not find a declaration file for module '@googlemaps/three'. '.../google-maps-webgl/node_modules/@googlemaps/three/dist/index.esm.js' implicitly has an 'any' type. There are types at '.../google-maps-webgl/node_modules/@googlemaps/three/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@googlemaps/three' library may need to update its package.json or typings.
Describe the solution you'd like
Export the
dist/index.d.ts
as well.package.json before:
package.json after:
Describe alternatives you've considered
Making that change manually by editing the dependency inside my
node_modules
folder.The text was updated successfully, but these errors were encountered: