From c26f7371980418b56b816b13d265c9cc9d092f32 Mon Sep 17 00:00:00 2001 From: "Mengye (Max) Gong" <8364575+gongmax@users.noreply.github.com> Date: Fri, 4 Oct 2024 11:00:22 -0700 Subject: [PATCH] Update the go version upgrade template (#4011) --- .github/ISSUE_TEMPLATE/golang_version_upgrade.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/golang_version_upgrade.md b/.github/ISSUE_TEMPLATE/golang_version_upgrade.md index 99036461f2..42326bb316 100644 --- a/.github/ISSUE_TEMPLATE/golang_version_upgrade.md +++ b/.github/ISSUE_TEMPLATE/golang_version_upgrade.md @@ -13,9 +13,10 @@ Steps to upgrade Golang version: - [ ] `find . -name 'go.mod' -not -path '*/\.*' -execdir go mod edit -go= \;` - [ ] `find . -name 'go.mod' -not -path '*/\.*' -execdir go mod tidy \;` -- [ ] Update the Dockerfiles for `build` directory. At the root of the directory, run: +- [ ] Update the Dockerfiles for `build` directory. - `find build -type f \( -not -path '*/\.*' -and -not -path 'build/tmp/*' \) -exec sed -i 's/GO_VERSION=[0-9]\+\.[0-9]\+\.[0-9]\+/GO_VERSION=/g' {} \;` + - [ ] At the root of the directory, run: `find build -type f \( -not -path '*/\.*' -and -not -path 'build/tmp/*' \) -exec sed -i 's/GO_VERSION=[0-9]\+\.[0-9]\+\.[0-9]\+/GO_VERSION=/g' {} \;` + - [ ] Update the `golang` version for file `build/agones-bot/Dockerfile` to - [ ] Update the Dockerfiles for `examples` directory. At the root of the directory, run: - [ ] `find examples -name Dockerfile -exec sed -i 's/golang:[0-9]\+\.[0-9]\+-alpine/golang:-alpine/g' {} \;` @@ -31,9 +32,7 @@ Steps to upgrade Golang version: - [ ] `make bump-image IMAGENAME=supertuxkart-example VERSION=` - [ ] `make bump-image IMAGENAME=xonotic-example VERSION=` -- [ ] Create a PR for the above changes and send for review - -- [ ] After the above PR is approved, **before** merging it, run the following to generate and push the new example images: +- [ ] Run the following to generate and push the new example images: - [ ] In `examples/allocation-endpoint`, run: `make cloud-build` - [ ] In `examples/autoscaler-webhook`, run: `make cloud-build` - [ ] In `examples/crd-client`, run: `make cloud-build` @@ -43,4 +42,6 @@ Steps to upgrade Golang version: - [ ] In `examples/supertuxkart`, run: `make cloud-build` - [ ] In `examples/xonotic`, run: `make cloud-build` -- [ ] Merge the above PR \ No newline at end of file +- [ ] Create a PR for the above changes and send for review + +- [ ] Merge the above PR after it is approved \ No newline at end of file