Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shaperglo hi_Deva will always fail as it will produce dotted circle #85

Open
mitradranirban opened this issue Oct 16, 2024 · 2 comments

Comments

@mitradranirban
Copy link

As my font failed I checked with NotoSansDevanagari-Regular

shaperglot check NotoSansDevanagari-Regular.ttf hi_Deva
Font does not fully support language 'hi_Deva'
 * FAIL: Shaper produced a dotted circle when shaping shaping the text 'अ ॄ ॐ ई ग ऑ ऐ श ब द ए ढ थ फ ऌ ण छ औ ळ ॉ ओ न भ ऽ ॅ आ ऍ ड ख व ञ इ ट ध ऊ च क त स ङ य प ठ ह झ म घ उ ज ल ऋ ष र'
 * FAIL: Shaper produced a dotted circle when shaping shaping the text 'अ ॄ ॐ ई ग ऑ ऐ श ब द ए ढ थ फ ऌ ण छ औ ळ ॉ ओ न भ ऽ ॅ आ ऍ ड ख व ञ इ ट ध ऊ च क त स ङ य प ठ ह झ म घ उ ज ल ऋ ष र'

As the test is placing stand alone vowel marks and considering a dotted circle as fail, all Devanagari font will fail the test. Please ensure marks and vowel marks are not place standalone

@simoncozens
Copy link
Collaborator

Thanks; this is an issue with the underlying language database, which I will fix.

@simoncozens
Copy link
Collaborator

The language data is now fixed; the issue here with shaperglot is that, as you say, it is shaping a mark with a dotted circle then complaining that a dotted circle was produced. That is fixed in the Rust implementation but not in the Python yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants