Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock button tooltip #1768

Closed
navv-1 opened this issue Nov 7, 2024 · 4 comments
Closed

Lock button tooltip #1768

navv-1 opened this issue Nov 7, 2024 · 4 comments
Labels
cosmetic bug Something doesn't look quite right CSS help wanted Extra attention is needed

Comments

@navv-1
Copy link
Contributor

navv-1 commented Nov 7, 2024

I just noticed the lock button tooltip is slightly clipped at the top.

Image

@justvanrossum justvanrossum moved this to 📋 Backlog in Fontra Project Nov 7, 2024
@justvanrossum justvanrossum added cosmetic bug Something doesn't look quite right help wanted Extra attention is needed CSS labels Nov 7, 2024
@giovanniTramonto
Copy link
Contributor

giovanniTramonto commented Dec 5, 2024

@justvanrossum When removing overflow-x + overflow-y from ui-form and overflow-y from div.ui-form clipping is gone.
Overflow could be set in .selection-info instead, but would require some general layout adjustments.
Actually, https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_anchor_positioning would be great, because anchor can be placed inside overflow: hidden, but the module was only releases this year in Chrome and Edge.

giovanniTramonto added a commit to giovanniTramonto/fontra that referenced this issue Dec 16, 2024
justvanrossum added a commit that referenced this issue Dec 17, 2024
@justvanrossum
Copy link
Collaborator

Fixed by #1861

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Fontra Project Dec 17, 2024
@giovanniTramonto
Copy link
Contributor

@justvanrossum As mentioned above, a great way to avoid similar issues with tooltip in the future is anchor positioning, since it’s not blocked by overflow: hidden. I found a polyfill https://anchor-positioning.oddbird.net/
The idea is to add an invisible top level element with utmost z-index that gets shown and attached to hovered anchors.

@justvanrossum
Copy link
Collaborator

While I like the concept of anchor positioning, I don't like to depend on a (huge!) polyfill. Maybe we should come back to this once anchor positioning is supported everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic bug Something doesn't look quite right CSS help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

3 participants