Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance location improperly determined #1034

Open
madig opened this issue Aug 31, 2023 · 1 comment
Open

Instance location improperly determined #1034

madig opened this issue Aug 31, 2023 · 1 comment
Labels
Instantiator Issues relating to generating static instances with the instantiator module.

Comments

@madig
Copy link
Collaborator

madig commented Aug 31, 2023

location = {**self.default_design_location, **instance.location}

This accesses instance.location instead of calling getFullLocation or whatsitcalled. Instances with a label instead of an old-school location will be placed at the default location. The instantiator should probably remember the labels of the DS and use them, or keep a reference to the DS to be able to resolve locations...

@madig madig added the Instantiator Issues relating to generating static instances with the instantiator module. label Aug 31, 2023
@madig
Copy link
Collaborator Author

madig commented Aug 31, 2023

Maybe the DS5to4 splitter should set this on instances explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Instantiator Issues relating to generating static instances with the instantiator module.
Projects
None yet
Development

No branches or pull requests

1 participant