Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Dispatcher UI: Browserstack process #138

Open
vv-monsalve opened this issue Oct 10, 2019 · 4 comments
Open

Dispatcher UI: Browserstack process #138

vv-monsalve opened this issue Oct 10, 2019 · 4 comments

Comments

@vv-monsalve
Copy link

Browserstack can take long, so it should be a warning message about this. Also, a way to actually end works that don't respond anymore... although that will be hard to decide

@graphicore
Copy link
Contributor

this is from a chat I had with @vv-monsalve

Also, a way to actually end works that don't respond anymore... although that will be hard to decide

What I meant is something like a timeout or heartbeat for workers. To eventually kill them and to inform the dispatcher with an error message.

@m4rc1e
Copy link
Contributor

m4rc1e commented Oct 11, 2019

In gftools qa, I recently refactored it to speed up diffbrowsers for large families. It now runs on 4 styles at a time. It used to just be 1 style.

https://github.com/googlefonts/gftools/blob/master/bin/gftools-qa.py#L176

@graphicore
Copy link
Contributor

In gftools qa, I recently refactored it to speed up diffbrowsers for large families. It now runs on 4 styles at a time. It used to just be 1 style.

Ok, cool. How does it work? Can you point me to the commits that changed it?

@graphicore
Copy link
Contributor

@m4rc1e: ping (follow up of what I mentioned in the call)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants