Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Hermetic Build integration tests should be run in GCB #3340

Open
diegomarquezp opened this issue Nov 6, 2024 · 0 comments
Open

The Hermetic Build integration tests should be run in GCB #3340

diegomarquezp opened this issue Nov 6, 2024 · 0 comments
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@diegomarquezp
Copy link
Contributor

diegomarquezp commented Nov 6, 2024

Currently, our Docker image is built and pushed after a PR is merged. This setup doesn't catch situations where a new build procedure may work differently or simply break in the posterior GCB build.

For example, after merging #3324, which contained changes to the Dockerfile, we started seeing build errors not captured in our integration tests. This is because the integration test uses the GH actions environment. Therefore, moving our ITs to GCB will replicate the build behavior that occurs after merging the PR and would prevent any build errors from being merged.

@diegomarquezp diegomarquezp added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants