Skip to content

Commit e81fd4f

Browse files
committed
fix: record error attributes on attempt span when operation fails
1 parent f89860e commit e81fd4f

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/OpenTelemetryTracingTracer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ public void operationFailed(Throwable error) {
212212

213213
private void recordErrorAndEndOperation(@Nullable Throwable error) {
214214
if (attemptSpan != null) {
215-
endAttempt();
215+
recordErrorAndEndAttempt(error);
216216
}
217217
if (operationSpan == null) {
218218
return;

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/OpenTelemetryTracingTracerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -832,6 +832,7 @@ void testOperationFailed_endsActiveAttemptSpan() {
832832
openTelemetryTracingTracer.attemptStarted(new Object(), 1);
833833
openTelemetryTracingTracer.operationFailed(new RuntimeException("operation failed"));
834834

835+
verify(span).setAttribute(ObservabilityAttributes.STATUS_MESSAGE_ATTRIBUTE, "operation failed");
835836
verify(span).end();
836837
verify(operationSpan).end();
837838
}

0 commit comments

Comments
 (0)