fix: set StatusCode.ERROR on failed and cancelled operation spans

Author: jinseopkim0

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/OpenTelemetryTracingTracer.java

@@ -35,6 +35,7 @@
 import io.opentelemetry.api.trace.Span;
 import io.opentelemetry.api.trace.SpanBuilder;
 import io.opentelemetry.api.trace.SpanKind;
+import io.opentelemetry.api.trace.StatusCode;
 import io.opentelemetry.api.trace.Tracer;
 import java.util.HashMap;
 import java.util.Map;
@@ -238,9 +239,12 @@ private void recordErrorAndEndOperation(@Nullable Throwable error) {
       localOperationSpan.setAllAttributes(ObservabilityUtils.toOtelAttributes(responseAttributes));
     }
 
-    if (error != null && !Strings.isNullOrEmpty(error.getMessage())) {
-      localOperationSpan.setAttribute(
-          ObservabilityAttributes.STATUS_MESSAGE_ATTRIBUTE, error.getMessage());
+    if (error != null) {
+      localOperationSpan.setStatus(StatusCode.ERROR);
+      if (!Strings.isNullOrEmpty(error.getMessage())) {
+        localOperationSpan.setAttribute(
+            ObservabilityAttributes.STATUS_MESSAGE_ATTRIBUTE, error.getMessage());
+      }
     }
 
     localOperationSpan.end();

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/OpenTelemetryTracingTracerTest.java

@@ -751,6 +751,7 @@ public Object getTransportCode() {
     verify(operationSpan).setAllAttributes(attrsCaptor.capture());
     verify(operationSpan)
         .setAttribute(ObservabilityAttributes.STATUS_MESSAGE_ATTRIBUTE, "custom failure");
+    verify(operationSpan).setStatus(io.opentelemetry.api.trace.StatusCode.ERROR);
     verify(operationSpan).end();
 
     Map<AttributeKey<?>, Object> captured = attrsCaptor.getValue().asMap();
@@ -769,6 +770,7 @@ void testOperationCancelled_endsOperationSpanWithCancelledStatus() {
 
     ArgumentCaptor<Attributes> attrsCaptor = ArgumentCaptor.forClass(Attributes.class);
     verify(operationSpan).setAllAttributes(attrsCaptor.capture());
+    verify(operationSpan).setStatus(io.opentelemetry.api.trace.StatusCode.ERROR);
     verify(operationSpan).end();
 
     assertThat(attrsCaptor.getValue().asMap())
@@ -829,6 +831,7 @@ void testOperationFailed_endsActiveAttemptSpan() {
 
     verify(span).setAttribute(ObservabilityAttributes.STATUS_MESSAGE_ATTRIBUTE, "operation failed");
     verify(span).end();
+    verify(operationSpan).setStatus(io.opentelemetry.api.trace.StatusCode.ERROR);
     verify(operationSpan).end();
   }
 }