Skip to content

Commit 37ac2c5

Browse files
committed
chore(spanner-jdbc): address review comments
1 parent 13f5a2a commit 37ac2c5

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

java-spanner-jdbc/samples/spring-data-mybatis/googlesql/src/test/java/com/google/cloud/spanner/sample/ApplicationEmulatorTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.testcontainers.DockerClientFactory;
2929
import org.testcontainers.containers.GenericContainer;
3030
import org.testcontainers.containers.wait.strategy.Wait;
31-
import org.testcontainers.images.PullPolicy;
3231
import org.testcontainers.utility.DockerImageName;
3332

3433
@RunWith(JUnit4.class)
@@ -42,7 +41,6 @@ public static void startEmulator() {
4241
emulator =
4342
new GenericContainer<>(
4443
DockerImageName.parse("gcr.io/cloud-spanner-emulator/emulator:latest"))
45-
.withImagePullPolicy(PullPolicy.alwaysPull())
4644
.withExposedPorts(9010)
4745
.waitingFor(Wait.forLogMessage(".*gRPC server listening at.*\\n", 1));
4846
emulator.start();
@@ -54,6 +52,11 @@ public static void cleanup() {
5452
if (emulator != null) {
5553
emulator.stop();
5654
}
55+
System.clearProperty("open_telemetry.enabled");
56+
System.clearProperty("open_telemetry.project");
57+
System.clearProperty("spanner.emulator");
58+
System.clearProperty("spanner.auto_start_emulator");
59+
System.clearProperty("spanner.endpoint");
5760
}
5861

5962
@Test

java-spanner-jdbc/samples/spring-data-mybatis/postgresql/src/test/java/com/google/cloud/spanner/sample/ApplicationEmulatorTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.testcontainers.DockerClientFactory;
2929
import org.testcontainers.containers.GenericContainer;
3030
import org.testcontainers.containers.wait.strategy.Wait;
31-
import org.testcontainers.images.PullPolicy;
3231
import org.testcontainers.utility.DockerImageName;
3332

3433
@RunWith(JUnit4.class)
@@ -42,7 +41,6 @@ public static void startEmulator() {
4241
emulator =
4342
new GenericContainer<>(
4443
DockerImageName.parse("gcr.io/cloud-spanner-emulator/emulator:latest"))
45-
.withImagePullPolicy(PullPolicy.alwaysPull())
4644
.withExposedPorts(9010)
4745
.waitingFor(Wait.forLogMessage(".*gRPC server listening at.*\\n", 1));
4846
emulator.start();
@@ -54,6 +52,10 @@ public static void cleanup() {
5452
if (emulator != null) {
5553
emulator.stop();
5654
}
55+
System.clearProperty("open_telemetry.enabled");
56+
System.clearProperty("open_telemetry.project");
57+
System.clearProperty("spanner.emulator");
58+
System.clearProperty("spanner.endpoint");
5759
}
5860

5961
@Test

0 commit comments

Comments
 (0)