run_gcloud_command splits args containing spaces (breaks filter expressions)

[ndelitski]

Description

When passing a compound filter expression as a single element in the args array to run_gcloud_command, the server appears to split the argument on spaces, causing gcloud to receive them as separate positional arguments.

Steps to Reproduce

Call run_gcloud_command with a gcloud logging read filter:

{
  "args": [
    "logging",
    "read",
    "resource.type=cloud_run_revision AND resource.labels.service_name=temporal-ui AND severity>=WARNING",
    "--project=my-project",
    "--limit=30",
    "--format=json(timestamp,severity,textPayload,jsonPayload)"
  ]
}

Expected Behavior

The filter string should be passed as a single argument to gcloud, equivalent to:

gcloud logging read 'resource.type=cloud_run_revision AND resource.labels.service_name=temporal-ui AND severity>=WARNING' --project=my-project --limit=30 --format=json(...)

Actual Behavior

Error: UnrecognizedArgumentsError: unrecognized arguments:
  AND
  resource.labels.service_name=temporal-ui
  severity>=WARNING (did you mean '--verbosity'?)

The AND and subsequent filter clauses are treated as separate arguments, indicating the single array element was split on spaces somewhere in the execution pipeline.

Environment

• @google-cloud/gcloud-mcp v0.5.3
• Client: Claude Code (CLI)
• macOS, Node.js 22

Notes

This likely affects any gcloud subcommand that accepts a positional argument containing spaces (e.g., logging read FILTER, compute instances list --filter=EXPR). Commands with simple args like run services describe work correctly.

Possible cause: the gcloud meta lint-gcloud-commands validation step or the argument passing to child_process.spawn may be joining and re-splitting the args array.

[ndelitski]

Root Cause

Found it in packages/gcloud-mcp/src/tools/run_gcloud_command.ts line 80:

const parsedLintResult = await gcloud.lint(args.join(' '));

args.join(' ') destroys argument boundaries. When the args array contains an element with spaces (e.g., "resource.type=cloud_run_revision AND severity>=WARNING"), joining flattens it into the command string. gcloud meta lint-gcloud-commands --command-string then parses AND as a separate argument, causing the UnrecognizedArgumentsError.

The actual execution on line 102 (gcloud.invoke(args)) correctly passes the original array to child_process.spawn — but it never reaches that point because lint fails first.

Fix

Quote args containing spaces before joining for lint:

const commandString = args
  .map((arg) => (arg.includes(' ') ? `'${arg}'` : arg))
  .join(' ');
const parsedLintResult = await gcloud.lint(commandString);

This preserves shell-style argument boundaries for the --command-string flag while keeping the actual execution path untouched.

Happy to open a PR if you'd like.