Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Wait Duration Not Used? #69

Open
elliot-chung opened this issue Dec 16, 2024 · 0 comments
Open

Minimum Wait Duration Not Used? #69

elliot-chung opened this issue Dec 16, 2024 · 0 comments

Comments

@elliot-chung
Copy link

elliot-chung commented Dec 16, 2024

I've been writing a NodeJS implementation for a Webrisk client by following the Webrisk documentation found here. This page mentions that both the hashes.search and threatLists.computeDiff API calls both occasionally return a minimumWaitDuration property and that the associated API call shouldn't be used until the deadline has passed.

My main issue is that I can't seem to find where this functionality is implemented in this repository. (Notably, the safebrowsing repository does implement this functionality in its database.go file). Am I misunderstanding something or is this the intended implementation?

On top of the implementation details, I'm also curious about the following:

  • When calling threatList.computeDiff the API returns a recommendedNextDiff property. How do these two properties compare? Is minimumWaitDuration guaranteed to end after recommendedNextDiff? Before? Neither?
  • How long is minimumWaitDuration typically? If the client encounters a prefix hit in its local database before minimumWaitDuration has concluded, is it practical to wait until the end of the duration to get full confirmation from the server or should the client just report a detection alongside a possible warning of false positives?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant