You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Request#parseNetworkResponse claims it's okay to return null if a response can't be parsed. In reality, it seems like this would almost guarantee an NPE either in CacheDispatcher or ExecutorDelivery, so unless someone has an entirely custom ResponseDelivery, they probably already are returning Response.error rather than null. We should verify this and consider updating the Javadoc accordingly.
The text was updated successfully, but these errors were encountered:
To add to this, if someone uses a ResponseDelivery that does not call ExecutorDelivery, they also have to implement their own RequestQueue, since both Request#finish and RequestQueue#finish are package-private, and are the only way of removing the request from the RequestQueue's current requests.
Request#parseNetworkResponse claims it's okay to return null if a response can't be parsed. In reality, it seems like this would almost guarantee an NPE either in CacheDispatcher or ExecutorDelivery, so unless someone has an entirely custom ResponseDelivery, they probably already are returning Response.error rather than null. We should verify this and consider updating the Javadoc accordingly.
The text was updated successfully, but these errors were encountered: