Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/CETCOMPAT linker option is not set in Bazel build #1113

Closed
yukawa opened this issue Nov 2, 2024 · 0 comments · Fixed by #1164
Closed

/CETCOMPAT linker option is not set in Bazel build #1113

yukawa opened this issue Nov 2, 2024 · 0 comments · Fixed by #1164
Assignees
@yukawa

Comments

@yukawa
Copy link
Collaborator

yukawa commented Nov 2, 2024 •
edited
Loading

Description

For GYP Windows build we have enabled Hardware Enforced Stack Protection as follows.

This is not yet done in Bazel build.

Steps to reproduce

Steps to reproduce the behavior:

  1. Build Mozc for Windows with Bazel.
  2. dumpbin /HEADERS mozc_tip64.dll
  3. dumpbin /HEADERS mozc_server.exe

Expected behavior

At the step 2 and 3, you can find the following section.

        00000001 extended DLL characteristics
                   CET compatible

Version or commit-id

e1b40ed

Environment

  • OS: Windows 11 23H2
@yukawa yukawa self-assigned this Nov 2, 2024
yukawa added a commit to yukawa/mozc that referenced this issue Jan 21, 2025
@yukawa
Specify /CETCOMPAT in Bazel Windows build
32cc643 
Win32 x64/x86 executables built with GYP are already declared to be
Intel CET compatible (google#835).

With this commit those executables built with Bazel also become Intel
CET compatible.

Closes google#1113.
@yukawa yukawa mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yukawa yukawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify /CETCOMPAT in Bazel Windows build yukawa/mozc
1 participant
@yukawa