Deflake docker in gVisor docker tests. #12253
Open
+42
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl825263678
branch
from
3cba799 to
88e36f6
Compare
The docker client uses in the tests can catch the docker errors for commands on the host's docker. However, when we start docker daemon inside a docker container, the client can't catch the failure from the nested error message from the docker daemon running inside. To deflake the test, we always retry until we can get expected output from execution logs in the command or timeout. PiperOrigin-RevId: 825263678
copybara-service
bot
force-pushed
the
test/cl825263678
branch
from
88e36f6 to
746ae31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deflake docker in gVisor docker tests.
The docker client uses in the tests can catch the docker errors for commands
on the host's docker. However, when we start docker daemon inside a docker
container, the client can't catch the failure from the nested error message
from the docker daemon running inside.
To deflake the test, we always retry until we can get expected output from
execution logs in the command or timeout.