Only report CPU percentage per period if period is > 0

tklauser · tklauser · commit 9f8280461a34 · 2022-07-08T10:33:55.000+02:00
The change in #154 lead to the CPU usage being reported for a 0s duration: cpu usage (0s): NaN% Fix this by only reporting CPU usage per period if the user specified a positive duration.
diff --git a/main.go b/main.go
@@ -156,8 +156,10 @@ func processInfo(pid int, period time.Duration) {
 	if v, err := p.CPUPercent(); err == nil {
 		fmt.Printf("cpu usage:\t%.3f%%\n", v)
 	}
-	if v, err := cpuPercentWithinTime(p, period); err == nil {
-		fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v)
+	if period > 0 {
+		if v, err := cpuPercentWithinTime(p, period); err == nil {
+			fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v)
+		}
 	}
 	if v, err := p.Username(); err == nil {
 		fmt.Printf("username:\t%v\n", v)

Original file line number	Diff line number	Diff line change
`@@ -156,8 +156,10 @@ func processInfo(pid int, period time.Duration) {`
`156`	`156`	`if v, err := p.CPUPercent(); err == nil {`
`157`	`157`	`fmt.Printf("cpu usage:\t%.3f%%\n", v)`
`158`	`158`	`}`
`159`		`- if v, err := cpuPercentWithinTime(p, period); err == nil {`
`160`		`- fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v)`
	`159`	`+ if period > 0 {`
	`160`	`+ if v, err := cpuPercentWithinTime(p, period); err == nil {`
	`161`	`+ fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v)`
	`162`	`+ }`
`161`	`163`	`}`
`162`	`164`	`if v, err := p.Username(); err == nil {`
`163`	`165`	`fmt.Printf("username:\t%v\n", v)`