-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting overly long lines does not respect --lines
range restriction
#1114
Comments
jdcormie
added a commit
to grpc/grpc-java
that referenced
this issue
Jun 24, 2024
https://github.com/grpc/grpc-java/blob/master/CONTRIBUTING.md#code-style We've been talking about an incremental approach in #1664 but google/google-java-format#1114 causes a bunch of manual formatting toil every time I run ~/google-java-format-diff.py because we have a LOT of lines >100 characters. Establishing a gjf-clean baseline will make things a lot easier for me.
Hi, @cushon I've been getting this issue while using Can I try to work on the fix? |
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this issue
Aug 13, 2024
https://github.com/grpc/grpc-java/blob/master/CONTRIBUTING.md#code-style We've been talking about an incremental approach in grpc#1664 but google/google-java-format#1114 causes a bunch of manual formatting toil every time I run ~/google-java-format-diff.py because we have a LOT of lines >100 characters. Establishing a gjf-clean baseline will make things a lot easier for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Let Test.java be:
What I did:
$ google-java-format --lines 1:1 Test.java | diff Test.java -
What I expected to happen: No diff, since line 1 is already correctly formatted.
What actually happens:
The text was updated successfully, but these errors were encountered: