add map between severity and overdue minutes #1144
Conversation
src/logging.cc
Outdated
| @@ -1286,7 +1299,14 @@ LogCleaner::LogCleaner() = default; | |||
|
|
|||
| void LogCleaner::Enable(const std::chrono::minutes& overdue) { | |||
| enabled_ = true; | |||
| overdue_ = overdue; | |||
| for (int i = GLOG_INFO; i < NUM_SEVERITIES; i++) { | |||
| overdue_per_severity_[static_cast<LogSeverity>(i)] = overdue; | |||
There was a problem hiding this comment.
Fill the map only with the severity set by the user.
HNOONa-0
force-pushed
the
feat/overdue-per-severity
branch
from
cb1b4aa to
55e6f47
Compare
|
Hey @sergiud , I have made some improvements, I switched from a map to a vector for better lookup speed and cleaner implementation. I also addressed all the issues you pointed out. PTAL! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
- Coverage 62.22% 61.95% -0.27%
==========================================
Files 19 19
Lines 2324 2363 +39
Branches 845 856 +11
==========================================
+ Hits 1446 1464 +18
- Misses 596 616 +20
- Partials 282 283 +1
|
HNOONa-0
force-pushed
the
feat/overdue-per-severity
branch
from
f0e5b47 to
314903e
Compare
|
Hey @sergiud, I initially made the wrong assumptions, I thought log files must have severity in their names, but that’s not the case. I have added methods to enable, disable logging for both types of files (with and without severity in their names) and exported those functions. I also added a test file that checks for deferred cleanup logic, but I haven’t integrated it with CMake yet. |
I have added an
unordered_mapthat can store a severity and it's corresponding overdue time to theLogCleanerobject. The modifications should be backwards compatible. If this idea is correct, we can preform some optimizations, like keeping a cache of filepaths whose severities have been computed.Fixes: #882