Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overpass font not correctly aligned #5795

Open
JosuaMeier opened this issue Jan 18, 2023 · 6 comments
Open

Overpass font not correctly aligned #5795

JosuaMeier opened this issue Jan 18, 2023 · 6 comments
Assignees
Milestone

Comments

@JosuaMeier
Copy link

JosuaMeier commented Jan 18, 2023

Describe the bug
In version 4.0.0 the overpass font is not vertically aligned center.
Bildschirmfoto 2023-01-16 um 14 30 32

Here is the correct version 3.0.5:
Bildschirmfoto 2023-01-16 um 14 33 49

To Reproduce
https://jsbin.com/gotevucaku/edit?html,css,output

Correct with version 3.0.5 version:
https://jsbin.com/niwevodahe/1/edit?html,css,output

Expected behavior
Font should be vertically center aligned. (worked in version 3.x)

Additional context
Mac, Chrome

@JosuaMeier
Copy link
Author

Any updates here?

@RosaWagner
Copy link
Contributor

Hi @JosuaMeier, thanks for the report. Unfortunately we won't be able to fix that cause it would break websites served with this font. More info here: https://googlefonts.github.io/gf-guide/onboarding#font-upgrades

@RosaWagner RosaWagner removed the -- Needs manager's opinion from upper level label Jun 1, 2023
@RosaWagner RosaWagner removed this from Google Fonts Jun 1, 2023
@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Apr 25, 2024

We're going to have a look at the diffenator comparisons between what the Red Hat team have in their main branch and what we ship to understand the impact on line spacing in order to achieve the improved vertical alignment with e.g., icons. We'll decide if this is an acceptable change relative to our current production release.

@tarjep
Copy link

tarjep commented Nov 12, 2024

What is the status on this? This misalignment is really annoying.

@thlinard
Copy link
Contributor

thlinard commented Nov 12, 2024

Issue upstream: RedHatOfficial/Overpass#91 (no new commit since September 10, 2021).

@thlinard
Copy link
Contributor

thlinard commented Nov 12, 2024

Btw, in version 4, typoDescender and hheaDescender have been set to -756, which is equal to the value of yMin. This value is the value of ‎| 007C VERTICAL LINE, and even though this matches what is done in the first example of Google Fonts documentation | Vertical metrics, it was not relevant to do so in this case.

The conversion of old values (Overpass Heavy v3.0.5: yMin= -378, hheaLineGap = 266, typoDescender= -250 and hheaDescender= -284, Use_Typo_Metrics enabled in fsSelection) ​​​​that was done when switching to variable format would deserve to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

7 participants