From 91e890dc41e1bc68d262016cca786dcca885a6f8 Mon Sep 17 00:00:00 2001
From: MoonFruit <dkmoonfruit@gmail.com>
Date: Mon, 21 Apr 2025 14:23:14 +0800
Subject: [PATCH] Ignore empty strings for StringConcatToTextBlock

Fixes #4918
---
 .../google/errorprone/bugpatterns/StringConcatToTextBlock.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/StringConcatToTextBlock.java b/core/src/main/java/com/google/errorprone/bugpatterns/StringConcatToTextBlock.java
index 86ec008160f..5b811517f09 100644
--- a/core/src/main/java/com/google/errorprone/bugpatterns/StringConcatToTextBlock.java
+++ b/core/src/main/java/com/google/errorprone/bugpatterns/StringConcatToTextBlock.java
@@ -98,6 +98,9 @@ && isSameType(getType(parent), state.getSymtab().stringType, state)) {
             .filter(t -> t.kind().equals(Tokens.TokenKind.STRINGLITERAL))
             .map(t -> t.stringVal())
             .collect(toImmutableList());
+    if (strings.isEmpty()) {
+        return NO_MATCH;
+    }
     boolean trailingNewline = getLast(strings).endsWith("\n");
     // Only migrate if there are enough lines to make it worthwhile. Escaping the trailing newline
     // slightly reduces the readability benefit of migrating, so require an extra line to make it