Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlaceholderUnificationVisitor using javac 21 API #4846

Open
msridhar opened this issue Feb 26, 2025 · 0 comments
Open

PlaceholderUnificationVisitor using javac 21 API #4846

msridhar opened this issue Feb 26, 2025 · 0 comments

Comments

@msridhar
Copy link
Contributor

In f093681 the PlaceholderUnificationVisitor class was modified to call CaseTree.getGuard():

error-prone/core/src/main/java/com/google/errorprone/refaster/PlaceholderUnificationVisitor.java

Line 665 in cc12b63

s -> unifyExpression(node.getGuard(), s),

But, this API was only introduced in JDK 21:

https://github.com/openjdk/jdk/blob/9477c705c0bd5ce2d445abb5ca44d46656fc315f/src/jdk.compiler/share/classes/com/sun/source/tree/CaseTree.java#L78-L84

So I think this code will fail if it is run on JDK 17 (which Error Prone still supports). Maybe this wasn't detected on CI due to missing test coverage?
copybara-service bot pushed a commit that referenced this issue Mar 5, 2025
@graememorgan
Restore pre-21 workaround in PlaceholderUnificationVisitor.
81e5287 
Fixes external #4846 hopefully.

PiperOrigin-RevId: 733359172
@copybara-service copybara-service bot mentioned this issue Mar 5, 2025
Merged
copybara-service bot pushed a commit that referenced this issue Mar 5, 2025
@graememorgan
Restore pre-21 workaround in PlaceholderUnificationVisitor.
0bc6e8a 
Fixes external #4846 hopefully.

PiperOrigin-RevId: 733719644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msridhar