Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadSafe is not a valid checker name #4833

Open
commonquail opened this issue Feb 21, 2025 · 0 comments · May be fixed by #4850
Open

ThreadSafe is not a valid checker name #4833

commonquail opened this issue Feb 21, 2025 · 0 comments · May be fixed by #4850

Comments

@commonquail
Copy link

In v2.36.0, https://errorprone.info/bugpattern/ThreadSafe seems to have an implementation in ThreadSafeChecker.java by the advertised name, but it cannot be activated by either name:

$ ./mvnw clean test-compile -DepFlags='-XepDisableAllChecks -Xep:ThreadSafe:WARN'
[INFO] Scanning for projects...
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:compile (default-compile) on project example: Fatal error compiling: ThreadSafe is not a valid checker name -> [Help 1]

I think this is because it is not named in BuiltInCheckerSuppliers.java (and never has been).
commonquail added a commit to commonquail/error-prone that referenced this issue Feb 26, 2025
@commonquail
ThreadSafe: recognize name
6306407 
Error Prone advertises https://errorprone.info/bugpattern/ThreadSafe but
does not recognize the name:

> Fatal error compiling: ThreadSafe is not a valid checker name

The implementing checker, `ThreadSafeChecker`, is missing from the index
of built-in checkers. Add it to the disabled checkers alongside the
other experimental checkers.

References: google#4833
@commonquail commonquail linked a pull request Feb 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ThreadSafe: recognize name commonquail/error-prone
1 participant
@commonquail