Reconsider special handling of static constants in BoxedPrimitiveEquality

[PBoddington]

For BoxedPrimitiveEquality, if either side of the == is a static final constant, it's not considered a match.

For example, for the code

public void test(Boolean bool) {
    final Boolean bool2 = Boolean.FALSE;
    boolean result = bool == bool2;
}

there is a match: error: [BoxedPrimitiveEquality] Comparison using reference equality instead of value equality.

On the other hand, for

public void test(Boolean bool) {
    boolean result = bool == Boolean.FALSE;
}

there is no match.

Note that this special handling for constants does not occur for ReferenceEquality, so both of the above pieces of code match ReferenceEquality.

Would it be possible to reconsider this special handling? Shouldn't comparing boxed primitives with == be an error in every situation?

I'm using errorprone version 2.36.0.

[graememorgan]

Thanks, we agree. We took a look over existing violations of the stricter form of the check, and none of them look like a good idea to allow.

[PBoddington]

Thanks, we agree. We took a look over existing violations of the stricter form of the check, and none of them look like a good idea to allow.

Thank you. Really appreciate this fast response.